Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1913913002: GetChangeDescriptionFromGitiles followup: future todo for no gitiles. (Closed)

Created:
4 years, 7 months ago by tandrii(chromium)
Modified:
4 years, 7 months ago
Reviewers:
Bons
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GetChangeDescriptionFromGitiles followup: future todo for no gitiles. R=andybons@chromium.org BUG=603207, 605563 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300194

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M gerrit_util.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tandrii(chromium)
4 years, 7 months ago (2016-04-25 19:31:23 UTC) #1
Bons
lgtm https://codereview.chromium.org/1913913002/diff/1/gerrit_util.py File gerrit_util.py (right): https://codereview.chromium.org/1913913002/diff/1/gerrit_util.py#newcode494 gerrit_util.py:494: # Note: Gerrit isntances that chrome infrastructure uses ...
4 years, 7 months ago (2016-04-25 20:06:25 UTC) #2
tandrii(chromium)
https://codereview.chromium.org/1913913002/diff/1/gerrit_util.py File gerrit_util.py (right): https://codereview.chromium.org/1913913002/diff/1/gerrit_util.py#newcode494 gerrit_util.py:494: # Note: Gerrit isntances that chrome infrastructure uses thus ...
4 years, 7 months ago (2016-04-26 14:26:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913913002/20001
4 years, 7 months ago (2016-04-26 14:26:18 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 14:28:50 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300194

Powered by Google App Engine
This is Rietveld 408576698