[DevTools] Move last inspected objects to V8InspectorSessionImpl

[DevTools] Move last inspected objects to V8InspectorSessionImpl

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf
Cr-Commit-Position: refs/heads/master@{#389688}

[kozy, 2016-04-25 17:10:44]

Dmitry, please take a look.

[dgozman, 2016-04-25 18:20:29]

https://codereview.chromium.org/1916023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8Console.h (right):

https://codereview.chromium.org/1916023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8Console.h:59: static void
firstInspectedObject(const v8::FunctionCallbackInfo<v8::Value>& info) {
inspectedObject(info, 0); }
I'd name these inspectedObject0...4. WDYT?

https://codereview.chromium.org/1916023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
(right):

https://codereview.chromium.org/1916023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h:139:
protocol::Vector<OwnPtr<Inspectable>> m_inspectedObjects;
This goes to session. In fact, all V8RuntimeAgent public methods will go to
session as well.

[kozy, 2016-04-25 20:31:55]

Patchset #3 (id:40001) has been deleted

[kozy, 2016-04-25 20:33:27]

All done.

https://codereview.chromium.org/1916023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8Console.h (right):

https://codereview.chromium.org/1916023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8Console.h:59: static void
firstInspectedObject(const v8::FunctionCallbackInfo<v8::Value>& info) {
inspectedObject(info, 0); }
On 2016/04/25 18:20:28, dgozman wrote:
> I'd name these inspectedObject0...4. WDYT?

Done.

https://codereview.chromium.org/1916023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
(right):

https://codereview.chromium.org/1916023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h:139:
protocol::Vector<OwnPtr<Inspectable>> m_inspectedObjects;
On 2016/04/25 18:20:29, dgozman wrote:
> This goes to session. In fact, all V8RuntimeAgent public methods will go to
> session as well.

Done.

[dgozman, 2016-04-26 00:24:15]

lgtm

https://codereview.chromium.org/1916023002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
(right):

https://codereview.chromium.org/1916023002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h:57:
static const unsigned inspectedObjectBufferSize = 5;
kInspectedObjectBufferSize

https://codereview.chromium.org/1916023002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
(right):

https://codereview.chromium.org/1916023002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h:122: bool
enabled() const { return m_enabled; }
Revert?

[kozy, 2016-04-26 00:29:32]

Description was changed from

==========
[DevTools] Move last inspected objects to V8RuntimeAgent

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move last inspected objects to V8InspectorSessionImpl

BUG=595206
R=dgozman@chromium.org
==========

[kozy, 2016-04-26 00:29:48]

All done.

https://codereview.chromium.org/1916023002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
(right):

https://codereview.chromium.org/1916023002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h:57:
static const unsigned inspectedObjectBufferSize = 5;
On 2016/04/26 00:24:15, dgozman wrote:
> kInspectedObjectBufferSize

Done.

https://codereview.chromium.org/1916023002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
(right):

https://codereview.chromium.org/1916023002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h:122: bool
enabled() const { return m_enabled; }
On 2016/04/26 00:24:15, dgozman wrote:
> Revert?

Done.

[kozy, 2016-04-26 00:30:59]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-04-26 00:30:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1916023002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-04-26 00:31:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916023002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916023002/100001

[commit-bot: I haz the power, 2016-04-26 00:35:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 00:35:27]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kozy, 2016-04-26 00:57:31]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-04-26 00:57:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1916023002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-04-26 00:57:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916023002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916023002/120001

[commit-bot: I haz the power, 2016-04-26 04:00:53]

Description was changed from

==========
[DevTools] Move last inspected objects to V8InspectorSessionImpl

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move last inspected objects to V8InspectorSessionImpl

BUG=595206
R=dgozman@chromium.org
==========

[commit-bot: I haz the power, 2016-04-26 04:00:54]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-04-26 04:01:52]

Description was changed from

==========
[DevTools] Move last inspected objects to V8InspectorSessionImpl

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move last inspected objects to V8InspectorSessionImpl

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf
Cr-Commit-Position: refs/heads/master@{#389688}
==========

[commit-bot: I haz the power, 2016-04-26 04:01:53]

Patchset 6 (id:??) landed as
https://crrev.com/c749d3e1f04d7cedea33adb280229e7b923f20cf
Cr-Commit-Position: refs/heads/master@{#389688}