Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

Issue 1916023002: [DevTools] Move last inspected objects to V8InspectorSessionImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-part-command-line-api-to-native
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
index e539dc38d89d7a2cc7444ce7b5161fb28dc86485..939c24bdde88c0ea2b0ab9c7b86e5834c5299222 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
@@ -43,23 +43,6 @@ inline void v8SetReturnValue(const CallbackInfo& info, bool value)
}
-void V8InjectedScriptHost::inspectedObjectCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- if (info.Length() < 1)
- return;
-
- v8::Isolate* isolate = info.GetIsolate();
- if (!info[0]->IsInt32() && !isolate->IsExecutionTerminating()) {
- isolate->ThrowException(v8::Exception::TypeError(toV8String(isolate, "argument has to be an integer")));
- return;
- }
-
- v8::Local<v8::Context> context = isolate->GetCurrentContext();
- InjectedScriptHost* host = V8InjectedScriptHost::unwrap(context, info.Holder());
- V8RuntimeAgent::Inspectable* object = host->inspectedObject(info[0].As<v8::Int32>()->Value());
- v8SetReturnValue(info, object ? object->get(context) : v8::Local<v8::Value>());
-}
-
void V8InjectedScriptHost::internalConstructorNameCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
if (info.Length() < 1 || !info[0]->IsObject())
@@ -302,7 +285,6 @@ using InjectedScriptHostWrapper = InspectorWrapper<InjectedScriptHost, hiddenPro
const InjectedScriptHostWrapper::V8MethodConfiguration V8InjectedScriptHostMethods[] = {
{"inspect", V8InjectedScriptHost::inspectCallback},
- {"inspectedObject", V8InjectedScriptHost::inspectedObjectCallback},
{"internalConstructorName", V8InjectedScriptHost::internalConstructorNameCallback},
{"formatAccessorsAsProperties", V8InjectedScriptHost::formatAccessorsAsProperties},
{"isTypedArray", V8InjectedScriptHost::isTypedArrayCallback},

Powered by Google App Engine
This is Rietveld 408576698