third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js - Issue 1916023002: [DevTools] Move last inspected objects to V8InspectorSessionImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

Issue 1916023002: [DevTools] Move last inspected objects to V8InspectorSessionImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-part-command-line-api-to-native

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Console.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

index b83a1f6d8b5eb87ac5c6b275196b4805f48b95b1..878192eb5f106e0c2fcd786b1d65bcc42ea6aa47 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

@@ -618,10 +618,6 @@ InjectedScript.prototype = {

var commandLineAPIImpl = this._commandLineAPIImpl;

for (var member of members)

nativeCommandLineAPI[member] = bind(commandLineAPIImpl[member], commandLineAPIImpl);

- for (var i = 0; i < 5; ++i) {

- var member = "$" + i;

- nativeCommandLineAPI[member] = bind(commandLineAPIImpl._inspectedObject, commandLineAPIImpl, i);

- }

var functionToStringMap = new Map([

["$", "function $(selector, [startNode]) { [Command Line API] }"],

["$$", "function $$(selector, [startNode]) { [Command Line API] }"],

@@ -1342,14 +1338,6 @@ CommandLineAPIImpl.prototype = {

/**

- * @param {number} num

- */

- _inspectedObject: function(num)

- {

- return InjectedScriptHost.inspectedObject(num);

- },

- /**

* @param {!Array.<string>|string=} types

* @return {!Array.<string>}