Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1915793002: Remove a |readonly| member of MediaStreamTrack (Closed)

Created:
4 years, 8 months ago by Taylor.Hoon
Modified:
4 years, 7 months ago
CC:
avayvod+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, haraken, hongchan, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, kinuko+watch, mcasas+watch+mediastream_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-content_chromium.org, philipj_slow, posciak+watch_chromium.org, Raymond Toy, tommyw+watchlist_chromium.org, xjz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a |readonly| member of MediaStreamTrack Spec reference: http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 - removal was in the April 6 editors' draft. The attribute was never exposed in our IDL files. BUG=598704 Committed: https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7 Cr-Commit-Position: refs/heads/master@{#392373}

Patch Set 1 #

Patch Set 2 : Fix some compile errors in the "test_runner" compile target. #

Patch Set 3 : Remove a |readonly| argument in unittest files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -49 lines) Patch
M components/test_runner/mock_web_user_media_client.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M components/test_runner/mock_webrtc_peer_connection_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/renderer/media_stream_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/audio_track_recorder_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/canvas_capture_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_video_capturer_source_unittest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_video_source_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_video_track_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/mock_media_stream_registry.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/pepper_to_video_track_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/remote_media_stream_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/speech_recognition_audio_sink_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_source_provider_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_local_audio_track_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamSource.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915793002/1
4 years, 8 months ago (2016-04-24 09:56:28 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/55514) cast_shell_linux on ...
4 years, 8 months ago (2016-04-24 10:14:07 UTC) #6
hta - Chromium
This patch seems to have not compiled on most of the bots. Please review the ...
4 years, 8 months ago (2016-04-24 12:09:52 UTC) #7
hta - Chromium
At least one compile error relates to components/test_runner/mock_web_user_media_client.cc - it's good to try to compile ...
4 years, 8 months ago (2016-04-24 12:16:23 UTC) #8
Taylor.Hoon
On 2016/04/24 12:16:23, hta - Chromium wrote: > At least one compile error relates to ...
4 years, 8 months ago (2016-04-24 12:37:40 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915793002/20001
4 years, 8 months ago (2016-04-24 18:49:14 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/59290) linux_chromium_gn_chromeos_rel on ...
4 years, 8 months ago (2016-04-24 19:00:45 UTC) #13
hta - Chromium
I recognize this one ... you need to build "content_unittests" and fix the resulting errors.
4 years, 7 months ago (2016-04-27 19:42:13 UTC) #14
Taylor.Hoon
On 2016/04/27 19:42:13, hta - Chromium wrote: > I recognize this one ... you need ...
4 years, 7 months ago (2016-05-07 06:06:31 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915793002/40001
4 years, 7 months ago (2016-05-07 15:25:57 UTC) #17
hta - Chromium
Now that it passes the tests, I hope this is ready for owners' review. I've ...
4 years, 7 months ago (2016-05-07 16:22:48 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223849)
4 years, 7 months ago (2016-05-07 16:44:30 UTC) #23
tommi (sloooow) - chröme
lgtm
4 years, 7 months ago (2016-05-09 10:58:17 UTC) #24
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-09 15:46:34 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915793002/40001
4 years, 7 months ago (2016-05-09 16:08:21 UTC) #27
hta - Chromium
lgtm
4 years, 7 months ago (2016-05-09 16:08:47 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-09 18:29:37 UTC) #30
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 18:32:09 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d7b5609c2f590a7c5ce59a40c5e1f39ffefbcdc7
Cr-Commit-Position: refs/heads/master@{#392373}

Powered by Google App Engine
This is Rietveld 408576698