third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h - Issue 1915793002: Remove a |readonly| member of MediaStreamTrack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h

Issue 1915793002: Remove a |readonly| member of MediaStreamTrack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove a |readonly| argument in unittest files Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp ('k') | third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h

diff --git a/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h b/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h

index 6769ec36a4d496e4e1bf9f7561d00ee1bdac22fe..ebc1852c9db560eacd8ace85fbe31f438b4766c7 100644

--- a/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h

+++ b/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h

@@ -69,13 +69,12 @@ public:

ReadyStateEnded = 2

};

- static MediaStreamSource* create(const String& id, StreamType, const String& name, bool remote, bool readonly, ReadyState = ReadyStateLive, bool requiresConsumer = false);

+ static MediaStreamSource* create(const String& id, StreamType, const String& name, bool remote, ReadyState = ReadyStateLive, bool requiresConsumer = false);

const String& id() const { return m_id; }

StreamType type() const { return m_type; }

const String& name() const { return m_name; }

bool remote() const { return m_remote; }

- bool readonly() const { return m_readonly; }

void setReadyState(ReadyState);

ReadyState getReadyState() const { return m_readyState; }

@@ -102,13 +101,12 @@ public:

DECLARE_TRACE();

private:

- MediaStreamSource(const String& id, StreamType, const String& name, bool remote, bool readonly, ReadyState, bool requiresConsumer);

+ MediaStreamSource(const String& id, StreamType, const String& name, bool remote, ReadyState, bool requiresConsumer);

String m_id;

StreamType m_type;

String m_name;

bool m_remote;

- bool m_readonly;

ReadyState m_readyState;

bool m_requiresConsumer;

HeapHashSet<WeakMember<Observer>> m_observers;