recipe_modules/tryserver/example.expected/with_rietveld_patch.json - Issue 1915463002: depot_tools: add infra_paths recipe module for infra-specific paths

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: recipe_modules/tryserver/example.expected/with_rietveld_patch.json

Issue 1915463002: depot_tools: add infra_paths recipe module for infra-specific paths (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « recipe_modules/tryserver/example.expected/with_git_patch.json ('k') | recipe_modules/tryserver/example.expected/with_svn_patch.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "[DEPOT_TOOLS]/apply_issue.py",	6 "[ROOT]/b/depot_tools/apply_issue.py",

7 "-r",	7 "-r",

8 "[SLAVE_BUILD]",	8 "[CWD]",

9 "-i",	9 "-i",

10 "12853011",	10 "12853011",

11 "-p",	11 "-p",

12 "1",	12 "1",

13 "-s",	13 "-s",

14 "https://codereview.chromium.org",	14 "https://codereview.chromium.org",

15 "--no-auth"	15 "--no-auth"

16 ],	16 ],

17 "cwd": "[SLAVE_BUILD]",

18 "name": "apply_issue",	17 "name": "apply_issue",

19 "~followup_annotations": [	18 "~followup_annotations": [

20 "@@@STEP_LINK@Applied issue 12853011@https://codereview.chromium.org/12853 011@@@"	19 "@@@STEP_LINK@Applied issue 12853011@https://codereview.chromium.org/12853 011@@@"

21 ]	20 ]

22 },	21 },

23 {	22 {

24 "cmd": [	23 "cmd": [

25 "git",	24 "git",

26 "diff",	25 "diff",

27 "--cached",	26 "--cached",

28 "--name-only"	27 "--name-only"

29 ],	28 ],

30 "cwd": "[SLAVE_BUILD]",	29 "cwd": "[CWD]",

31 "name": "git diff to analyze patch",	30 "name": "git diff to analyze patch",

32 "stdout": "/path/to/tmp/",	31 "stdout": "/path/to/tmp/",

33 "~followup_annotations": [	32 "~followup_annotations": [

34 "@@@STEP_LOG_LINE@files@foo.cc@@@",	33 "@@@STEP_LOG_LINE@files@foo.cc@@@",

35 "@@@STEP_LOG_END@files@@@",	34 "@@@STEP_LOG_END@files@@@",

36 "@@@SET_BUILD_PROPERTY@failure_type@\"INVALID_TEST_RESULTS\"@@@",	35 "@@@SET_BUILD_PROPERTY@failure_type@\"INVALID_TEST_RESULTS\"@@@",

37 "@@@SET_BUILD_PROPERTY@subproject_tag@\"v8\"@@@"	36 "@@@SET_BUILD_PROPERTY@subproject_tag@\"v8\"@@@"

38 ]	37 ]

39 },	38 },

40 {	39 {

41 "cmd": [	40 "cmd": [

42 "python",	41 "python",

43 "-u",	42 "-u",

44 "import sys; sys.exit(1)"	43 "import sys; sys.exit(1)"

45 ],	44 ],

46 "cwd": "[SLAVE_BUILD]",

47 "name": "fail",	45 "name": "fail",

48 "~followup_annotations": [	46 "~followup_annotations": [

49 "step returned non-zero exit code: 1",	47 "step returned non-zero exit code: 1",

50 "@@@STEP_TEXT@foo@@@",	48 "@@@STEP_TEXT@foo@@@",

51 "@@@STEP_FAILURE@@@",	49 "@@@STEP_FAILURE@@@",

52 "@@@SET_BUILD_PROPERTY@failure_hash@\"c2311ad770732eade3d2f48247abd147e40a 70e7\"@@@"	50 "@@@SET_BUILD_PROPERTY@failure_hash@\"c2311ad770732eade3d2f48247abd147e40a 70e7\"@@@"

53 ]	51 ]

54 },	52 },

55 {	53 {

56 "name": "$result",	54 "name": "$result",

57 "reason": "Step('fail') failed with return_code 1",	55 "reason": "Step('fail') failed with return_code 1",

58 "status_code": 1	56 "status_code": 1

59 }	57 }

60 ]	58 ]

OLD	NEW