recipe engine: extract infra-specific paths out of the engine

recipe engine: extract infra-specific paths out of the engine

BUG=chromium:605919
Committed: https://github.com/luci/recipes-py/commit/f712a9271eb999e8b43c48ea9404f4bef393e486

[Paweł Hajdan Jr., 2016-04-22 13:52:09]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 13:52:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906323003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906323003/1

[commit-bot: I haz the power, 2016-04-22 13:56:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 13:56:49]

Dry run: Try jobs failed on following builders:
  Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/...)

[Paweł Hajdan Jr., 2016-04-22 13:59:21]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 13:59:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906323003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906323003/20001

[commit-bot: I haz the power, 2016-04-22 14:01:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 14:01:39]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-04-22 14:02:44]

phajdan.jr@chromium.org changed reviewers:
+ iannucci@chromium.org, martiniss@chromium.org

[iannucci, 2016-04-23 20:13:09]

lgtm % tmp_base for some examples.

Also, wdyt about s/tmp_base/tmp/ ? I'm not sure if the _base part is really
necessary.

https://chromiumcodereview.appspot.com/1906323003/diff/20001/recipe_modules/g...
File recipe_modules/generator_script/example.py (right):

https://chromiumcodereview.appspot.com/1906323003/diff/20001/recipe_modules/g...
recipe_modules/generator_script/example.py:21: api.path['checkout'] =
api.path['tmp_base'].join('checkout')
is this a good example? I mean; if someone copy-pasted this recipe, is this
something they'd have to change, or is this actually going to be a recommended
practice? Maybe this should just be relative to the current working directory?

[Paweł Hajdan Jr., 2016-04-26 08:34:15]

Good point about s/tmp_base/tmp. Done.

https://codereview.chromium.org/1906323003/diff/20001/recipe_modules/generato...
File recipe_modules/generator_script/example.py (right):

https://codereview.chromium.org/1906323003/diff/20001/recipe_modules/generato...
recipe_modules/generator_script/example.py:21: api.path['checkout'] =
api.path['tmp_base'].join('checkout')
On 2016/04/23 at 20:13:08, iannucci wrote:
> is this a good example? I mean; if someone copy-pasted this recipe, is this
something they'd have to change, or is this actually going to be a recommended
practice? Maybe this should just be relative to the current working directory?

Well, it's not worse than before. Nothing is checking things out there anyway.
We discussed this offline.

If you have ideas how to further improve this, please share.

[Paweł Hajdan Jr., 2016-04-26 08:34:19]

The CQ bit was checked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-04-26 08:34:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1906323003/#ps40001
(title: "tmp")

[commit-bot: I haz the power, 2016-04-26 08:34:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906323003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906323003/40001

[commit-bot: I haz the power, 2016-04-26 08:36:28]

Description was changed from

==========
recipe engine: extract infra-specific paths out of the engine

BUG=chromium:605919
==========

to

==========
recipe engine: extract infra-specific paths out of the engine

BUG=chromium:605919

Committed:
https://github.com/luci/recipes-py/commit/f712a9271eb999e8b43c48ea9404f4bef39...
==========

[commit-bot: I haz the power, 2016-04-26 08:36:29]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/f712a9271eb999e8b43c48ea9404f4bef39...

[tandrii(chromium), 2016-04-26 18:36:44]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1923013002/ by tandrii@chromium.org.

The reason for reverting is: this Cl's untrival roll is breaking skia bots. See
https://codereview.chromium.org/1917243002/
.