third_party/WebKit/Source/core/workers/WorkerThread.cpp - Issue 1915373002: Implement empty WorkerInternals interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.cpp

Issue 1915373002: Implement empty WorkerInternals interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trials-in-service-workers

Patch Set: update expectations Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp ('k') | third_party/WebKit/Source/web/WebTestingSupport.cpp » ('j') | third_party/WebKit/public/platform/Platform.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerThread.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.cpp b/third_party/WebKit/Source/core/workers/WorkerThread.cpp

index 28bd0b050f3d9f8dcd5b72fbeaecf6a22c8bd448..642daec7fbd905815418c4ebc4fc82c91e534241 100644

--- a/third_party/WebKit/Source/core/workers/WorkerThread.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerThread.cpp

@@ -222,6 +222,8 @@ void WorkerThread::initialize(PassOwnPtr<WorkerThreadStartupData> startupData)

if (m_workerGlobalScope->scriptController()->isContextInitialized()) {

m_workerReportingProxy.didInitializeWorkerContext();

+ v8::HandleScope handleScope(isolate());

+ Platform::current()->workerContextCreated(m_workerGlobalScope->scriptController()->context());

haraken 2016/05/04 04:03:56 Maybe can we reuse m_workerReportingProxy.didIniti

Marijn Kruisselbrink 2016/05/04 05:11:04 At some point we still need some API to call out t

}

CachedMetadataHandler* handler = workerGlobalScope()->createWorkerScriptCachedMetadataHandler(scriptURL, cachedMetaData.get());