third_party/WebKit/public/platform/Platform.h - Issue 1915373002: Implement empty WorkerInternals interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/Platform.h

Issue 1915373002: Implement empty WorkerInternals interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trials-in-service-workers

Patch Set: update expectations Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/workers/WorkerThread.cpp ('K') | « third_party/WebKit/Source/web/WebTestingSupport.cpp ('k') | third_party/WebKit/public/web/WebTestingSupport.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/Platform.h

diff --git a/third_party/WebKit/public/platform/Platform.h b/third_party/WebKit/public/platform/Platform.h

index c7a244b6d8c49c5092b4e12956fe58912cc74be4..5c4bacbdea076a3361b32c738e323e868ecfbe30 100644

--- a/third_party/WebKit/public/platform/Platform.h

+++ b/third_party/WebKit/public/platform/Platform.h

@@ -55,6 +55,8 @@

#include "WebVector.h"

#include "base/metrics/user_metrics_action.h"

+#include <v8/include/v8.h>

jochen (gone - plz use gerrit) 2016/05/06 10:42:09 can you forward declare instead? namespace v8 { t

Marijn Kruisselbrink 2016/05/06 16:14:30 Not unless I also change the method to pass the v8

Marijn Kruisselbrink 2016/05/06 16:20:35 Which actually is probably better (at least not wo

class GrContext;

namespace blink {

@@ -618,6 +620,8 @@ public:

virtual WebTrialTokenValidator* trialTokenValidator() { return nullptr; }

+ virtual void workerContextCreated(v8::Local<v8::Context> worker) { }

protected:

Platform();

virtual ~Platform() { }