third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp - Issue 1915373002: Implement empty WorkerInternals interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

Issue 1915373002: Implement empty WorkerInternals interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trials-in-service-workers

Patch Set: update expectations Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/testing/WorkerInternals.idl ('k') | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

diff --git a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

index 7b225b9fe93d9fae92f45d91626d2661f61c5cdf..76b1d711395d707ce69f8c40036574efeffaaaec 100644

--- a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

+++ b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

@@ -31,6 +31,7 @@

#include "core/frame/LocalFrame.h"

#include "core/testing/InternalSettings.h"

#include "core/testing/Internals.h"

+#include "core/testing/WorkerInternals.h"

using namespace blink;

@@ -43,6 +44,8 @@ v8::Local<v8::Value> createInternalsObject(v8::Local<v8::Context> context)

ExecutionContext* executionContext = scriptState->getExecutionContext();

if (executionContext->isDocument())

return toV8(Internals::create(scriptState), global, scriptState->isolate());

+ if (executionContext->isWorkerGlobalScope())

+ return toV8(WorkerInternals::create(scriptState), global, scriptState->isolate());

return v8::Local<v8::Value>();

}