Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1915343004: Remove ApplicationImpl::ConnectToApplicationDeprecated(). (Closed)

Created:
4 years, 8 months ago by viettrungluu
Modified:
4 years, 8 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work788_fix_connect_to_app_deprecated_3_yaks
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove ApplicationImpl::ConnectToApplicationDeprecated(). (And also the now-unused outgoing_service_registries_ member.) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/12def7a303c3fc18ccc8e8192cdb43cf2c04fc36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M mojo/public/cpp/application/application_impl.h View 2 chunks +0 lines, -11 lines 0 comments Download
M mojo/public/cpp/application/lib/application_impl.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Depends on Patchset:

Issue 1924673002 Patch 1

Messages

Total messages: 5 (1 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/1924673002/.)
4 years, 8 months ago (2016-04-26 23:48:01 UTC) #1
vardhan
lgtm
4 years, 8 months ago (2016-04-26 23:58:31 UTC) #2
viettrungluu
On 2016/04/26 23:58:31, vardhan wrote: > lgtm But what about https://codereview.chromium.org/1924673002/? :)
4 years, 8 months ago (2016-04-27 00:06:52 UTC) #3
viettrungluu
4 years, 8 months ago (2016-04-27 04:09:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
12def7a303c3fc18ccc8e8192cdb43cf2c04fc36 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698