Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: mojo/public/cpp/application/lib/application_impl.cc

Issue 1915343004: Remove ApplicationImpl::ConnectToApplicationDeprecated(). (Closed) Base URL: https://github.com/domokit/mojo.git@work788_fix_connect_to_app_deprecated_3_yaks
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/application/application_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/application/lib/application_impl.cc
diff --git a/mojo/public/cpp/application/lib/application_impl.cc b/mojo/public/cpp/application/lib/application_impl.cc
index 806800cc7309ae2f38b97e4f862c8437af1ae258..f9635286942cc91f68e348647baafae215de784a 100644
--- a/mojo/public/cpp/application/lib/application_impl.cc
+++ b/mojo/public/cpp/application/lib/application_impl.cc
@@ -33,21 +33,6 @@ ApplicationImpl::CreateApplicationConnector() {
return application_connector;
}
-ApplicationConnection* ApplicationImpl::ConnectToApplicationDeprecated(
- const String& application_url) {
- MOJO_CHECK(shell_);
- InterfaceHandle<ServiceProvider> local_services;
- InterfaceRequest<ServiceProvider> local_request = GetProxy(&local_services);
- ServiceProviderPtr remote_services;
- shell_->ConnectToApplication(application_url, GetProxy(&remote_services),
- std::move(local_services));
- internal::ServiceRegistry* registry = new internal::ServiceRegistry(
- this, application_url, application_url, remote_services.Pass(),
- local_request.Pass());
- outgoing_service_registries_.emplace_back(registry);
- return registry;
-}
-
void ApplicationImpl::WaitForInitialize() {
if (!shell_)
binding_.WaitForIncomingMethodCall();
@@ -67,7 +52,6 @@ void ApplicationImpl::Initialize(InterfaceHandle<Shell> shell,
shell_.set_connection_error_handler([this]() {
delegate_->Quit();
incoming_service_registries_.clear();
- outgoing_service_registries_.clear();
Terminate();
});
url_ = url;
« no previous file with comments | « mojo/public/cpp/application/application_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698