Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1924673002: ConnectToApplicationDeprecated() conversion/removal, part 3. (Closed)

Created:
4 years, 8 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

ConnectToApplicationDeprecated() conversion/removal, part 3. The last use of ConnectToApplicationDeprecated() is complicated, since both ServiceProvider directions are used. We hang on to ServiceProviderImpls (which are bound to requests whose corresponding handles were sent over ConnectToApplication()) and keep them alive (and of course service them), so that the TestB that we connected to can make requests on us. Instead of passing the ApplicationConnect* to the TestAImpl, we just pass it the ServiceProvider handle ("pointer"), so that the TestAImpl can connect to the TestB services. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7ab221305eab00f59b9378942f6ae74339f05609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M shell/application_manager/application_manager_unittest.cc View 5 chunks +23 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 8 months ago (2016-04-26 23:02:56 UTC) #1
vardhan
lgtm
4 years, 8 months ago (2016-04-27 00:43:05 UTC) #2
viettrungluu
4 years, 7 months ago (2016-04-27 04:09:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ab221305eab00f59b9378942f6ae74339f05609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698