Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1914923002: Rename all existing custom element classes as V0 (Closed)

Created:
4 years, 8 months ago by kojii
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, tfarina, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename all existing custom element classes as V0 This patch renames existing custom element classes as V0 in order to clarify which parts were modified or reviewed for the V1 spec. BUG=594918 Committed: https://crrev.com/32fca76b0a7f4ccfb2128f3400d8cc87a3c58e31 Cr-Commit-Position: refs/heads/master@{#389689}

Patch Set 1 #

Patch Set 2 : CustomElementV0 -> V0CustomElement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+874 lines, -4645 lines) Patch
D third_party/WebKit/Source/bindings/core/v8/CustomElementBinding.h View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/CustomElementBinding.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.h View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp View 1 chunk +0 lines, -291 lines 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.h View 1 5 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp View 1 11 chunks +28 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp View 1 chunk +0 lines, -250 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.h View 1 2 chunks +11 lines, -11 lines 0 comments Download
A + third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp View 1 10 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/v8.gypi View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_attributes.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_methods.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/attributes.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 21 chunks +40 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +41 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMImplementation.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 7 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentInit.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentInit.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElement.h View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElement.cpp View 1 chunk +0 lines, -156 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementAsyncImportMicrotaskQueue.h View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementAsyncImportMicrotaskQueue.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementCallbackInvocation.h View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementCallbackInvocation.cpp View 1 chunk +0 lines, -140 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementCallbackQueue.h View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementCallbackQueue.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementDescriptor.h View 1 chunk +0 lines, -100 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementDescriptorHash.h View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementException.h View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementException.cpp View 1 chunk +0 lines, -90 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementLifecycleCallbacks.h View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskDispatcher.h View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskDispatcher.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskImportStep.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskImportStep.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskQueueBase.h View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskQueueBase.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskRunQueue.h View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskRunQueue.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskStep.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementObserver.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementObserver.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementProcessingStack.h View 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementProcessingStack.cpp View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementProcessingStep.h View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementRegistrationContext.h View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementRegistrationContext.cpp View 1 chunk +0 lines, -162 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementScheduler.h View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementScheduler.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementSyncMicrotaskQueue.h View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementSyncMicrotaskQueue.cpp View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeCandidateMap.h View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeCandidateMap.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElement.h View 1 4 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp View 1 5 chunks +20 lines, -20 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.h View 1 1 chunk +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp View 1 6 chunks +25 lines, -25 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackQueue.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackQueue.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementDefinition.h View 1 1 chunk +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementDefinition.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementDescriptor.h View 1 4 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementDescriptorHash.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementException.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementException.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementLifecycleCallbacks.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.h View 1 3 chunks +10 lines, -10 lines 0 comments Download
A third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp View 1 1 chunk +87 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskImportStep.h View 1 3 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskImportStep.cpp View 1 2 chunks +13 lines, -13 lines 0 comments Download
A third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskResolutionStep.h View 1 2 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskResolutionStep.cpp View 1 1 chunk +11 lines, -11 lines 0 comments Download
A third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskRunQueue.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskRunQueue.cpp View 1 3 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskStep.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementProcessingStack.h View 1 4 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementProcessingStack.cpp View 1 3 chunks +13 lines, -13 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementProcessingStep.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.h View 1 2 chunks +15 lines, -15 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.cpp View 1 4 chunks +26 lines, -26 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h View 1 3 chunks +15 lines, -15 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.cpp View 1 3 chunks +16 lines, -16 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementScheduler.h View 1 1 chunk +16 lines, -16 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementScheduler.cpp View 1 3 chunks +37 lines, -37 lines 0 comments Download
A third_party/WebKit/Source/core/dom/custom/V0CustomElementSyncMicrotaskQueue.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementSyncMicrotaskQueue.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.h View 1 1 chunk +16 lines, -16 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp View 1 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportChild.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportLoader.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebCustomElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebElement.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
kojii
PTAL. Should files under binding excluded? git failed to detect some files as renaming, but ...
4 years, 8 months ago (2016-04-25 07:25:57 UTC) #3
hayato
RS-LGTM If making them explicit is a good starting point to implement Custom Element v1, ...
4 years, 8 months ago (2016-04-25 07:51:18 UTC) #4
kojii
PTAL, PS2 uses V0CustomElement... convention.
4 years, 8 months ago (2016-04-25 09:47:33 UTC) #5
dominicc (has gone to gerrit)
This is nice and neat now that all these files are together w/ the prefix. ...
4 years, 8 months ago (2016-04-25 22:54:10 UTC) #6
dominicc (has gone to gerrit)
lgtm
4 years, 8 months ago (2016-04-25 22:54:14 UTC) #7
haraken
owner LGTM
4 years, 8 months ago (2016-04-26 03:20:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914923002/20001
4 years, 8 months ago (2016-04-26 04:04:21 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 04:11:13 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 04:12:34 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32fca76b0a7f4ccfb2128f3400d8cc87a3c58e31
Cr-Commit-Position: refs/heads/master@{#389689}

Powered by Google App Engine
This is Rietveld 408576698