Refactor drawContext/RenderTarget creation

Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914883002

Committed: https://skia.googlesource.com/skia/+/2f1c42e8448bbbadeb3df1c626faa90aa33f8907

Committed: https://skia.googlesource.com/skia/+/d4c741e3d0e0fa633399691c47f76b6c7841ee83

[robertphillips, 2016-04-24 16:50:52]

Description was changed from

==========
Refactor drawContext/RenderTarget creation
==========

to

==========
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-27 19:01:25]

Description was changed from

==========
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-27 19:01:25]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-04-27 19:03:23]

The most interesting changes are in GrContext.h/.cpp. The remaining changes are
just applications.

[robertphillips, 2016-04-27 19:03:30]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 19:03:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914883002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914883002/100001

[commit-bot: I haz the power, 2016-04-27 19:06:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 19:06:51]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[robertphillips, 2016-04-27 19:33:55]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 19:33:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914883002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914883002/120001

[bsalomon, 2016-04-27 19:42:10]

lgtm w/ question

https://codereview.chromium.org/1914883002/diff/120001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/1914883002/diff/120001/src/gpu/GrContext.cpp#...
src/gpu/GrContext.cpp:631: sk_sp<GrTexture> maskTexture;
Why is this called maskTexture?

[robertphillips, 2016-04-27 19:59:10]

https://codereview.chromium.org/1914883002/diff/120001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/1914883002/diff/120001/src/gpu/GrContext.cpp#...
src/gpu/GrContext.cpp:631: sk_sp<GrTexture> maskTexture;
On 2016/04/27 19:42:10, bsalomon wrote:
> Why is this called maskTexture?

Done - it was left over from copy & paste.

[robertphillips, 2016-04-27 19:59:16]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 19:59:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914883002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914883002/140001

[commit-bot: I haz the power, 2016-04-27 20:30:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 20:30:23]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-27 20:32:59]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-04-27 20:32:59]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1914883002/#ps140001
(title: "Fix variable name")

[commit-bot: I haz the power, 2016-04-27 20:33:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914883002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914883002/140001

[commit-bot: I haz the power, 2016-04-27 20:34:04]

Description was changed from

==========
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/2f1c42e8448bbbadeb3df1c626faa90aa33f8907
==========

[commit-bot: I haz the power, 2016-04-27 20:34:05]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/2f1c42e8448bbbadeb3df1c626faa90aa33f8907

[robertphillips, 2016-04-28 13:21:40]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1929833004/ by robertphillips@google.com.

The reason for reverting is: Experimental revert to see if this is blocking the
DEPS roll..

[robertphillips, 2016-04-28 14:08:48]

Description was changed from

==========
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/2f1c42e8448bbbadeb3df1c626faa90aa33f8907
==========

to

==========
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/2f1c42e8448bbbadeb3df1c626faa90aa33f8907
==========

[robertphillips, 2016-04-28 16:46:53]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 16:46:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914883002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914883002/140001

[commit-bot: I haz the power, 2016-04-28 16:47:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 16:47:48]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-28 16:54:13]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-04-28 16:54:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914883002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914883002/140001

[commit-bot: I haz the power, 2016-04-28 16:55:17]

Description was changed from

==========
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/2f1c42e8448bbbadeb3df1c626faa90aa33f8907
==========

to

==========
Refactor drawContext/RenderTarget creation
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/2f1c42e8448bbbadeb3df1c626faa90aa33f8907

Committed:
https://skia.googlesource.com/skia/+/d4c741e3d0e0fa633399691c47f76b6c7841ee83
==========

[commit-bot: I haz the power, 2016-04-28 16:55:18]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/d4c741e3d0e0fa633399691c47f76b6c7841ee83