Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 191483002: Get rid of multiprocess_test's debug_on_start arguments. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, jar (doing other things), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, jam, gavinp+memory_chromium.org, abarth-chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, asvitkine+watch_chromium.org, darin (slow to review), erikwright+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Get rid of multiprocess_test's debug_on_start arguments. (It was only ever given a "true" value once, and even that seemed dubious.) R=phajdan.jr@chromium.org TBR=darin@chromium.org, jeremy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255801

Patch Set 1 #

Patch Set 2 : missed one #

Patch Set 3 : rebased tot #

Patch Set 4 : restore ipc_switches.* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -87 lines) Patch
M base/debug/stack_trace_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/shared_memory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/stats_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_util_unittest.cc View 12 chunks +15 lines, -17 lines 0 comments Download
M base/test/multiprocess_test.h View 4 chunks +5 lines, -8 lines 0 comments Download
M base/test/multiprocess_test.cc View 2 chunks +7 lines, -19 lines 0 comments Download
M base/test/multiprocess_test_android.cc View 1 chunk +1 line, -3 lines 0 comments Download
M base/win/scoped_process_information_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/win/startup_information_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/common/multi_process_lock_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/common/sandbox_mac_diraccess_unittest.mm View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/sandbox_mac_unittest_helper.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M ipc/ipc_test_base.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download
M mojo/common/test/multiprocess_test_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/190943003/, which is dependent on https://codereview.chromium.org/189373002/.)
6 years, 9 months ago (2014-03-07 20:51:55 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 9 months ago (2014-03-07 22:10:29 UTC) #2
viettrungluu
OWNERS TBRs: jeremy - content/common/sandbox_mac* darin - everything else
6 years, 9 months ago (2014-03-08 23:07:31 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-08 23:07:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/191483002/60001
6 years, 9 months ago (2014-03-08 23:08:04 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 23:51:57 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234630
6 years, 9 months ago (2014-03-08 23:51:58 UTC) #7
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-09 00:10:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/191483002/60001
6 years, 9 months ago (2014-03-09 00:12:04 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-09 00:52:37 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234654
6 years, 9 months ago (2014-03-09 00:52:38 UTC) #11
viettrungluu
6 years, 9 months ago (2014-03-09 00:59:35 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 manually as r255801 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698