Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3643)

Unified Diff: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

Issue 191483002: Get rid of multiprocess_test's debug_on_start arguments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: restore ipc_switches.* Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/win/startup_information_unittest.cc ('k') | chrome/common/multi_process_lock_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
diff --git a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
index 2d4e196e83e63cf4d17cddae82bfa32b3aa8118d..62c681763ac2718282028715e079bf61a461884d 100644
--- a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
+++ b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
@@ -317,8 +317,7 @@ class CloudPrintProxyPolicyStartupTest : public base::MultiProcessTest,
virtual void OnChannelConnected(int32 peer_pid) OVERRIDE;
// MultiProcessTest implementation.
- virtual CommandLine MakeCmdLine(const std::string& procname,
- bool debug_on_start) OVERRIDE;
+ virtual CommandLine MakeCmdLine(const std::string& procname) OVERRIDE;
bool LaunchBrowser(const CommandLine& command_line, Profile* profile) {
int return_code = 0;
@@ -434,9 +433,9 @@ base::ProcessHandle CloudPrintProxyPolicyStartupTest::Launch(
kPrimaryIPCChannel + base::GlobalDescriptors::kBaseDescriptor));
base::LaunchOptions options;
options.fds_to_remap = &ipc_file_list;
- base::ProcessHandle handle = SpawnChildWithOptions(name, options, false);
+ base::ProcessHandle handle = SpawnChildWithOptions(name, options);
#else
- base::ProcessHandle handle = SpawnChild(name, false);
+ base::ProcessHandle handle = SpawnChild(name);
#endif
EXPECT_TRUE(handle);
return handle;
@@ -475,9 +474,8 @@ void CloudPrintProxyPolicyStartupTest::OnChannelConnected(int32 peer_pid) {
}
CommandLine CloudPrintProxyPolicyStartupTest::MakeCmdLine(
- const std::string& procname,
- bool debug_on_start) {
- CommandLine cl = MultiProcessTest::MakeCmdLine(procname, debug_on_start);
+ const std::string& procname) {
+ CommandLine cl = MultiProcessTest::MakeCmdLine(procname);
cl.AppendSwitchASCII(switches::kProcessChannelID, startup_channel_id_);
#if defined(OS_MACOSX)
cl.AppendSwitchASCII(kTestExecutablePath, executable_path_.value());
« no previous file with comments | « base/win/startup_information_unittest.cc ('k') | chrome/common/multi_process_lock_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698