Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: ipc/ipc_test_base.cc

Issue 191483002: Get rid of multiprocess_test's debug_on_start arguments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: restore ipc_switches.* Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel_posix_unittest.cc ('k') | mojo/common/test/multiprocess_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_test_base.cc
diff --git a/ipc/ipc_test_base.cc b/ipc/ipc_test_base.cc
index b25f844f07df84d92c5a7cd173fcef002e3ddc69..d3ad4d3d6f10a09b17a456f04320796fbb7fdae7 100644
--- a/ipc/ipc_test_base.cc
+++ b/ipc/ipc_test_base.cc
@@ -12,7 +12,6 @@
#include "base/threading/thread.h"
#include "base/time/time.h"
#include "ipc/ipc_descriptors.h"
-#include "ipc/ipc_switches.h"
#if defined(OS_POSIX)
#include "base/posix/global_descriptors.h"
@@ -96,11 +95,9 @@ bool IPCTestBase::StartClient() {
DCHECK(client_process_ == base::kNullProcessHandle);
std::string test_main = test_client_name_ + "TestClientMain";
- bool debug_on_start =
- CommandLine::ForCurrentProcess()->HasSwitch(switches::kDebugChildren);
#if defined(OS_WIN)
- client_process_ = SpawnChild(test_main, debug_on_start);
+ client_process_ = SpawnChild(test_main);
#elif defined(OS_POSIX)
base::FileHandleMappingVector fds_to_map;
const int ipcfd = channel_.get() ? channel_->GetClientFileDescriptor() :
@@ -110,7 +107,7 @@ bool IPCTestBase::StartClient() {
kPrimaryIPCChannel + base::GlobalDescriptors::kBaseDescriptor));
base::LaunchOptions options;
options.fds_to_remap = &fds_to_map;
- client_process_ = SpawnChildWithOptions(test_main, options, debug_on_start);
+ client_process_ = SpawnChildWithOptions(test_main, options);
#endif
return client_process_ != base::kNullProcessHandle;
« no previous file with comments | « ipc/ipc_channel_posix_unittest.cc ('k') | mojo/common/test/multiprocess_test_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698