Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: PRESUBMIT.py

Issue 1914073002: 🐺 Fix net_unittests on Android swarming by adding testserver as a data_dep (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gen-isolates-android
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/BUILD.gn » ('j') | net/tools/testserver/testserver.pydeps » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 'OS_OPENBSD', 310 'OS_OPENBSD',
311 'OS_POSIX', 311 'OS_POSIX',
312 'OS_QNX', 312 'OS_QNX',
313 'OS_SOLARIS', 313 'OS_SOLARIS',
314 'OS_WIN', 314 'OS_WIN',
315 ) 315 )
316 316
317 317
318 _ANDROID_SPECIFIC_PYDEPS_FILES = [ 318 _ANDROID_SPECIFIC_PYDEPS_FILES = [
319 'build/android/test_runner.pydeps', 319 'build/android/test_runner.pydeps',
320 'net/tools/testserver/testserver.pydeps',
320 ] 321 ]
321 322
322 _GENERIC_PYDEPS_FILES = [ 323 _GENERIC_PYDEPS_FILES = [
323 'build/secondary/tools/swarming_client/isolate.pydeps', 324 'build/secondary/tools/swarming_client/isolate.pydeps',
324 ] 325 ]
325 326
326 _ALL_PYDEPS_FILES = _ANDROID_SPECIFIC_PYDEPS_FILES + _GENERIC_PYDEPS_FILES 327 _ALL_PYDEPS_FILES = _ANDROID_SPECIFIC_PYDEPS_FILES + _GENERIC_PYDEPS_FILES
327 328
328 329
329 def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api): 330 def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
(...skipping 1788 matching lines...) Expand 10 before | Expand all | Expand 10 after
2118 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2119 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2119 input_api, 2120 input_api,
2120 output_api, 2121 output_api,
2121 json_url='http://chromium-status.appspot.com/current?format=json')) 2122 json_url='http://chromium-status.appspot.com/current?format=json'))
2122 2123
2123 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2124 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2124 input_api, output_api)) 2125 input_api, output_api))
2125 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2126 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2126 input_api, output_api)) 2127 input_api, output_api))
2127 return results 2128 return results
OLDNEW
« no previous file with comments | « no previous file | net/BUILD.gn » ('j') | net/tools/testserver/testserver.pydeps » ('J')

Powered by Google App Engine
This is Rietveld 408576698