Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1913533002:
[blink] Resolve symlinks in host binary paths in android layout tests. (Closed)
|
Created:
4 years, 8 months ago by jbudorick Modified:
4 years, 8 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews, blink-reviews, Dirk Pranke Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[blink] Resolve symlinks in host binary paths in android layout tests.
BUG=600458
Committed: https://crrev.com/c7a6777022144039d34949c5112001dec92247e1
Cr-Commit-Position: refs/heads/master@{#389699}
Patch Set 1 #Patch Set 2 : dpranke comment #Patch Set 3 : fix test #
Messages
Total messages: 24 (12 generated)
Description was changed from ========== [blink] Resolve symlinks in the android forwarder path in layout tests. BUG=600458 ========== to ========== [blink] Resolve symlinks in host binary paths in layout tests. BUG=600458 ==========
Description was changed from ========== [blink] Resolve symlinks in host binary paths in layout tests. BUG=600458 ========== to ========== [blink] Resolve symlinks in host binary paths in android layout tests. BUG=600458 ==========
Description was changed from ========== [blink] Resolve symlinks in host binary paths in android layout tests. BUG=600458 ========== to ========== [blink] Resolve symlinks in host binary paths in android layout tests. BUG=600458 ==========
jbudorick@chromium.org changed reviewers: + dpranke@chromium.org
Is the problem here that `adb push` doesn't follow symlinks? Or that in check_build() we reported true that a symlink existed even though the underlying file didn't? or both? Maybe we should resolve the path in AndroidCommands.push() instead if it's just the former? Or, at least, you could add some comments about why we need realpath()?
On 2016/04/22 23:57:19, Dirk Pranke wrote: > Is the problem here that `adb push` doesn't follow symlinks? Or that in > check_build() we reported true that a symlink existed even though the underlying > file didn't? or both? the former > > Maybe we should resolve the path in AndroidCommands.push() instead if it's just > the former? yeah, I like this idea better. > > Or, at least, you could add some comments about why we need realpath()?
ptal
lgtm
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913533002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913533002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jbudorick@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1913533002/#ps40001 (title: "fix test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913533002/40001
Message was sent while issue was closed.
Description was changed from ========== [blink] Resolve symlinks in host binary paths in android layout tests. BUG=600458 ========== to ========== [blink] Resolve symlinks in host binary paths in android layout tests. BUG=600458 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [blink] Resolve symlinks in host binary paths in android layout tests. BUG=600458 ========== to ========== [blink] Resolve symlinks in host binary paths in android layout tests. BUG=600458 Committed: https://crrev.com/c7a6777022144039d34949c5112001dec92247e1 Cr-Commit-Position: refs/heads/master@{#389699} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c7a6777022144039d34949c5112001dec92247e1 Cr-Commit-Position: refs/heads/master@{#389699} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
