third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py - Issue 1913533002: [blink] Resolve symlinks in host binary paths in android layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

Issue 1913533002: [blink] Resolve symlinks in host binary paths in android layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

index c62e0bda19f311dc1be7aef38c30320a1aa4957e..9b00de40104c26b86445c1f53fe7d334b0dfcd20 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

@@ -207,7 +207,8 @@ class AndroidCommands(object):

return self.run(['shell', 'ls', '-d', full_path]).strip() == full_path

def push(self, host_path, device_path, ignore_error=False):

- return self.run(['push', host_path, device_path], ignore_error=ignore_error)

+ return self.run(['push', os.path.realpath(host_path), device_path],

+ ignore_error=ignore_error)

def pull(self, device_path, host_path, ignore_error=False):

return self.run(['pull', device_path, host_path], ignore_error=ignore_error)

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py » ('j') | no next file with comments »