third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py - Issue 1913533002: [blink] Resolve symlinks in host binary paths in android layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

Issue 1913533002: [blink] Resolve symlinks in host binary paths in android layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

index cd924e1fc4668761a443d83b7418f65db0b570c0..c30d3a1d9e3f26084813802cbca6c7525e9b9604 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

@@ -28,6 +28,7 @@

import StringIO

import optparse

+import os

import sys

import time

import unittest

@@ -149,7 +150,8 @@ class AndroidCommandsTest(unittest.TestCase):

self.assertEquals('adb -s 123456789ABCDEF0 shell ls -d /some_directory', self._mock_executive.last_command())

android_commands.push('foo', 'bar')

- self.assertEquals('adb -s 123456789ABCDEF0 push foo bar', self._mock_executive.last_command())

+ self.assertEquals('adb -s 123456789ABCDEF0 push %s bar' % os.path.realpath('foo'),

+ self._mock_executive.last_command())

android_commands.pull('bar', 'foo')

self.assertEquals('adb -s 123456789ABCDEF0 pull bar foo', self._mock_executive.last_command())

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py ('k') | no next file » | no next file with comments »