Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1913273003: Remove stack trace from URLFetcher / URLRequest for debugging (Closed)

Created:
4 years, 8 months ago by Charlie Harrison
Modified:
4 years, 8 months ago
Reviewers:
eroman
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stack trace from URLFetcher / URLRequest for debugging This patch removes some debugging code that was dumped in AssertNoURLRequests. It isn't very helpful anymore. BUG=90971 Committed: https://crrev.com/f31e72ec019d02417b1e5207391d5436ea7391e8 Cr-Commit-Position: refs/heads/master@{#389606}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove a header include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M net/url_request/url_fetcher_core.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M net/url_request/url_fetcher_core.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request.h View 2 chunks +0 lines, -8 lines 0 comments Download
M net/url_request/url_request.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M net/url_request/url_request_context.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Charlie Harrison
PTAL. Matt gave the green light to remove this but let me know if you ...
4 years, 8 months ago (2016-04-25 13:44:47 UTC) #2
eroman
lgtm https://codereview.chromium.org/1913273003/diff/1/net/url_request/url_fetcher_core.h File net/url_request/url_fetcher_core.h (right): https://codereview.chromium.org/1913273003/diff/1/net/url_request/url_fetcher_core.h#newcode15 net/url_request/url_fetcher_core.h:15: #include "base/debug/stack_trace.h" delete https://codereview.chromium.org/1913273003/diff/1/net/url_request/url_request.h File net/url_request/url_request.h (left): https://codereview.chromium.org/1913273003/diff/1/net/url_request/url_request.h#oldcode640 ...
4 years, 8 months ago (2016-04-25 17:12:36 UTC) #3
Charlie Harrison
Thanks! https://codereview.chromium.org/1913273003/diff/1/net/url_request/url_fetcher_core.h File net/url_request/url_fetcher_core.h (right): https://codereview.chromium.org/1913273003/diff/1/net/url_request/url_fetcher_core.h#newcode15 net/url_request/url_fetcher_core.h:15: #include "base/debug/stack_trace.h" On 2016/04/25 at 17:12:36, eroman wrote: ...
4 years, 8 months ago (2016-04-25 21:28:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913273003/20001
4 years, 8 months ago (2016-04-25 21:29:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 23:28:08 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 23:30:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f31e72ec019d02417b1e5207391d5436ea7391e8
Cr-Commit-Position: refs/heads/master@{#389606}

Powered by Google App Engine
This is Rietveld 408576698