Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: net/url_request/url_request_context.cc

Issue 1913273003: Remove stack trace from URLFetcher / URLRequest for debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove a header include Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/url_request/url_request.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_context.h" 5 #include "net/url_request/url_request_context.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/debug/alias.h" 8 #include "base/debug/alias.h"
9 #include "base/debug/stack_trace.h"
10 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
11 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
12 #include "net/cookies/cookie_store.h" 11 #include "net/cookies/cookie_store.h"
13 #include "net/dns/host_resolver.h" 12 #include "net/dns/host_resolver.h"
14 #include "net/http/http_transaction_factory.h" 13 #include "net/http/http_transaction_factory.h"
15 #include "net/url_request/http_user_agent_settings.h" 14 #include "net/url_request/http_user_agent_settings.h"
16 #include "net/url_request/url_request.h" 15 #include "net/url_request/url_request.h"
17 16
18 namespace net { 17 namespace net {
19 18
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 89
91 void URLRequestContext::AssertNoURLRequests() const { 90 void URLRequestContext::AssertNoURLRequests() const {
92 int num_requests = url_requests_->size(); 91 int num_requests = url_requests_->size();
93 if (num_requests != 0) { 92 if (num_requests != 0) {
94 // We're leaking URLRequests :( Dump the URL of the first one and record how 93 // We're leaking URLRequests :( Dump the URL of the first one and record how
95 // many we leaked so we have an idea of how bad it is. 94 // many we leaked so we have an idea of how bad it is.
96 char url_buf[128]; 95 char url_buf[128];
97 const URLRequest* request = *url_requests_->begin(); 96 const URLRequest* request = *url_requests_->begin();
98 base::strlcpy(url_buf, request->url().spec().c_str(), arraysize(url_buf)); 97 base::strlcpy(url_buf, request->url().spec().c_str(), arraysize(url_buf));
99 int load_flags = request->load_flags(); 98 int load_flags = request->load_flags();
100 base::debug::StackTrace stack_trace(NULL, 0);
101 if (request->stack_trace())
102 stack_trace = *request->stack_trace();
103 base::debug::Alias(url_buf); 99 base::debug::Alias(url_buf);
104 base::debug::Alias(&num_requests); 100 base::debug::Alias(&num_requests);
105 base::debug::Alias(&load_flags); 101 base::debug::Alias(&load_flags);
106 base::debug::Alias(&stack_trace);
107 CHECK(false) << "Leaked " << num_requests << " URLRequest(s). First URL: " 102 CHECK(false) << "Leaked " << num_requests << " URLRequest(s). First URL: "
108 << request->url().spec().c_str() << "."; 103 << request->url().spec().c_str() << ".";
109 } 104 }
110 } 105 }
111 106
112 } // namespace net 107 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698