Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: net/url_request/url_request_context.cc

Issue 1913273003: Remove stack trace from URLFetcher / URLRequest for debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove a header include Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_context.cc
diff --git a/net/url_request/url_request_context.cc b/net/url_request/url_request_context.cc
index ed0aba3fe23a56ab796779d57709d414251d0d4f..a5ca5f1fc4528d191905048a8346e886850ab464 100644
--- a/net/url_request/url_request_context.cc
+++ b/net/url_request/url_request_context.cc
@@ -6,7 +6,6 @@
#include "base/compiler_specific.h"
#include "base/debug/alias.h"
-#include "base/debug/stack_trace.h"
#include "base/memory/ptr_util.h"
#include "base/strings/string_util.h"
#include "net/cookies/cookie_store.h"
@@ -97,13 +96,9 @@ void URLRequestContext::AssertNoURLRequests() const {
const URLRequest* request = *url_requests_->begin();
base::strlcpy(url_buf, request->url().spec().c_str(), arraysize(url_buf));
int load_flags = request->load_flags();
- base::debug::StackTrace stack_trace(NULL, 0);
- if (request->stack_trace())
- stack_trace = *request->stack_trace();
base::debug::Alias(url_buf);
base::debug::Alias(&num_requests);
base::debug::Alias(&load_flags);
- base::debug::Alias(&stack_trace);
CHECK(false) << "Leaked " << num_requests << " URLRequest(s). First URL: "
<< request->url().spec().c_str() << ".";
}
« no previous file with comments | « net/url_request/url_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698