Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1912793002: fiddle: Don't overwrite existing fiddle names unintentionally. (Closed)

Created:
4 years, 8 months ago by jcgregorio
Modified:
4 years, 8 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fiddle: Don't overwrite existing fiddle names unintentionally. BUG=skia: TBR=rmistry Committed: https://skia.googlesource.com/buildbot/+/2f0e606a02a22e8671d721c2c1a32e6ef79c1e5a

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : disabled #

Patch Set 4 : placeholder #

Patch Set 5 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -20 lines) Patch
M fiddle/go/fiddle/main.go View 1 2 3 4 3 chunks +14 lines, -8 lines 0 comments Download
M fiddle/go/named/named.go View 1 4 chunks +12 lines, -4 lines 1 comment Download
M fiddle/go/named/named_test.go View 1 1 chunk +9 lines, -3 lines 0 comments Download
M fiddle/res/imp/fiddle-sk.html View 1 2 3 6 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jcgregorio
4 years, 8 months ago (2016-04-22 14:54:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912793002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912793002/80001
4 years, 8 months ago (2016-04-22 14:54:12 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/buildbot/+/2f0e606a02a22e8671d721c2c1a32e6ef79c1e5a
4 years, 8 months ago (2016-04-22 14:59:29 UTC) #7
rmistry
4 years, 8 months ago (2016-04-25 12:59:18 UTC) #8
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/1912793002/diff/80001/fiddle/go/named/named.go
File fiddle/go/named/named.go (right):

https://codereview.chromium.org/1912793002/diff/80001/fiddle/go/named/named.g...
fiddle/go/named/named.go:75: if err == nil {
I had to look at this a few times to see what it was doing. Looks like line 74
returns an err if the name does not exist yet. If there is no error means that a
name already exists. Either way its ok to write has long as overwrite is True.

Powered by Google App Engine
This is Rietveld 408576698