Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: fiddle/go/named/named_test.go

Issue 1912793002: fiddle: Don't overwrite existing fiddle names unintentionally. (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 package named 1 package named
2 2
3 import ( 3 import (
4 "fmt" 4 "fmt"
5 "testing" 5 "testing"
6 6
7 "go.skia.org/infra/fiddle/go/store" 7 "go.skia.org/infra/fiddle/go/store"
8 8
9 "github.com/stretchr/testify/assert" 9 "github.com/stretchr/testify/assert"
10 ) 10 )
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 80
81 func TestAdd(t *testing.T) { 81 func TestAdd(t *testing.T) {
82 mock := &namedMock{ 82 mock := &namedMock{
83 lookup: map[string]string{ 83 lookup: map[string]string{
84 "star": "cbb8dee39e9f1576cd97c2d504db8eee", 84 "star": "cbb8dee39e9f1576cd97c2d504db8eee",
85 "bad_hash": "cbb8d", 85 "bad_hash": "cbb8d",
86 }, 86 },
87 } 87 }
88 88
89 names := New(mock) 89 names := New(mock)
90 » err := names.Add("a_good_name", "cbb8dee39e9f1576cd97c2d504db8eee", "use r") 90 » err := names.Add("a_good_name", "cbb8dee39e9f1576cd97c2d504db8eee", "use r", true)
91 assert.NoError(t, err) 91 assert.NoError(t, err)
92 92
93 » err = names.Add("no spaces in names", "cbb8dee39e9f1576cd97c2d504db8eee" , "user") 93 » err = names.Add("no spaces in names", "cbb8dee39e9f1576cd97c2d504db8eee" , "user", true)
94 assert.Error(t, err) 94 assert.Error(t, err)
95 95
96 » err = names.Add("a_good_name", "cbb8_bash_hash", "user") 96 » err = names.Add("a_good_name", "cbb8_bash_hash", "user", true)
97 assert.Error(t, err) 97 assert.Error(t, err)
98
99 err = names.Add("star", "cbb8dee39e9f1576cd97c2d504db8eee", "user", fals e)
100 assert.Equal(t, err, DuplicateNameErr)
101
102 err = names.Add("star", "cbb8dee39e9f1576cd97c2d504db8eee", "user", true )
103 assert.NoError(t, err)
98 } 104 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698