Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: fiddle/go/named/named_test.go

Issue 1912793002: fiddle: Don't overwrite existing fiddle names unintentionally. (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fiddle/go/named/named_test.go
diff --git a/fiddle/go/named/named_test.go b/fiddle/go/named/named_test.go
index 4281b07aac7a6d67b571665059583d8c8595b251..b531249c0d4b583c7e2d833b6406d46c71897efc 100644
--- a/fiddle/go/named/named_test.go
+++ b/fiddle/go/named/named_test.go
@@ -87,12 +87,18 @@ func TestAdd(t *testing.T) {
}
names := New(mock)
- err := names.Add("a_good_name", "cbb8dee39e9f1576cd97c2d504db8eee", "user")
+ err := names.Add("a_good_name", "cbb8dee39e9f1576cd97c2d504db8eee", "user", true)
assert.NoError(t, err)
- err = names.Add("no spaces in names", "cbb8dee39e9f1576cd97c2d504db8eee", "user")
+ err = names.Add("no spaces in names", "cbb8dee39e9f1576cd97c2d504db8eee", "user", true)
assert.Error(t, err)
- err = names.Add("a_good_name", "cbb8_bash_hash", "user")
+ err = names.Add("a_good_name", "cbb8_bash_hash", "user", true)
assert.Error(t, err)
+
+ err = names.Add("star", "cbb8dee39e9f1576cd97c2d504db8eee", "user", false)
+ assert.Equal(t, err, DuplicateNameErr)
+
+ err = names.Add("star", "cbb8dee39e9f1576cd97c2d504db8eee", "user", true)
+ assert.NoError(t, err)
}

Powered by Google App Engine
This is Rietveld 408576698