Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1912593002: [ic] Restore PROPERTY key tracking in keyed ICs (Closed)

Created:
4 years, 8 months ago by Jakob Kummerow
Modified:
4 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Restore PROPERTY key tracking in keyed ICs Non-vectorized KeyedLoadICs used to remember whether they had seen Names as keys; Crankshaft uses this information to avoid emitting elements accesses which would always deopt. This CL restores that functionality for vector ICs. BUG=chromium:594183 LOG=y R=mvstanton@chromium.org Committed: https://crrev.com/9bebebd909cf393bf7ea5512478a15aff70042d7 Cr-Commit-Position: refs/heads/master@{#35706}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -53 lines) Patch
M src/ic/ic.h View 5 chunks +1 line, -39 lines 1 comment Download
M src/ic/ic.cc View 9 chunks +19 lines, -11 lines 0 comments Download
M src/type-feedback-vector.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/type-feedback-vector.cc View 3 chunks +31 lines, -2 lines 0 comments Download
M src/type-info.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-594183.js View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
PTAL. https://codereview.chromium.org/1912593002/diff/1/src/ic/ic.h File src/ic/ic.h (left): https://codereview.chromium.org/1912593002/diff/1/src/ic/ic.h#oldcode270 src/ic/ic.h:270: static ExtraICState ComputeExtraICState(TypeofMode typeof_mode) { All the deletions ...
4 years, 8 months ago (2016-04-21 12:08:39 UTC) #1
mvstanton
Right on, LGTM.
4 years, 8 months ago (2016-04-21 12:13:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912593002/1
4 years, 8 months ago (2016-04-21 12:14:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 13:18:04 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bebebd909cf393bf7ea5512478a15aff70042d7
Cr-Commit-Position: refs/heads/master@{#35706}

Powered by Google App Engine
This is Rietveld 408576698