Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: src/ic/ic.h

Issue 1912593002: [ic] Restore PROPERTY key tracking in keyed ICs (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ic/ic.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic.h
diff --git a/src/ic/ic.h b/src/ic/ic.h
index d2bb5dd9c227d7b2f619ea0dec1fbe5bb402bde6..bfa3429e991ea0b1852bfa1c38676333df62cd44 100644
--- a/src/ic/ic.h
+++ b/src/ic/ic.h
@@ -106,7 +106,7 @@ class IC {
}
// Configure for most states.
- void ConfigureVectorState(IC::State new_state);
+ void ConfigureVectorState(IC::State new_state, Handle<Object> key);
// Configure the vector for MONOMORPHIC.
void ConfigureVectorState(Handle<Name> name, Handle<Map> map,
Handle<Code> handler);
@@ -267,10 +267,6 @@ class CallIC : public IC {
class LoadIC : public IC {
public:
- static ExtraICState ComputeExtraICState(TypeofMode typeof_mode) {
Jakob Kummerow 2016/04/21 12:08:38 All the deletions in this file were dead code anyw
- return LoadICState(typeof_mode).GetExtraICState();
- }
-
TypeofMode typeof_mode() const {
return LoadICState::GetTypeofMode(extra_ic_state());
}
@@ -320,20 +316,6 @@ class LoadIC : public IC {
class KeyedLoadIC : public LoadIC {
public:
- // ExtraICState bits (building on IC)
- class IcCheckTypeField
- : public BitField<IcCheckType, LoadICState::kNextBitFieldOffset, 1> {};
-
- static ExtraICState ComputeExtraICState(TypeofMode typeof_mode,
- IcCheckType key_type) {
- return LoadICState(typeof_mode).GetExtraICState() |
- IcCheckTypeField::encode(key_type);
- }
-
- static IcCheckType GetKeyType(ExtraICState extra_state) {
- return IcCheckTypeField::decode(extra_state);
- }
-
KeyedLoadIC(FrameDepth depth, Isolate* isolate,
KeyedLoadICNexus* nexus = NULL)
: LoadIC(depth, isolate, nexus) {
@@ -366,10 +348,6 @@ class KeyedLoadIC : public LoadIC {
class StoreIC : public IC {
public:
- static ExtraICState ComputeExtraICState(LanguageMode flag) {
- return StoreICState(flag).GetExtraICState();
- }
-
StoreIC(FrameDepth depth, Isolate* isolate, FeedbackNexus* nexus = NULL)
: IC(depth, isolate, nexus) {
DCHECK(IsStoreStub());
@@ -424,22 +402,6 @@ enum KeyedStoreIncrementLength { kDontIncrementLength, kIncrementLength };
class KeyedStoreIC : public StoreIC {
public:
- // ExtraICState bits (building on IC)
- // ExtraICState bits
- // When more language modes are added, these BitFields need to move too.
- STATIC_ASSERT(i::LANGUAGE_END == 3);
- class ExtraICStateKeyedAccessStoreMode
- : public BitField<KeyedAccessStoreMode, 3, 3> {}; // NOLINT
-
- class IcCheckTypeField : public BitField<IcCheckType, 6, 1> {};
-
- static ExtraICState ComputeExtraICState(LanguageMode flag,
- KeyedAccessStoreMode mode) {
- return StoreICState(flag).GetExtraICState() |
- ExtraICStateKeyedAccessStoreMode::encode(mode) |
- IcCheckTypeField::encode(ELEMENT);
- }
-
KeyedAccessStoreMode GetKeyedAccessStoreMode() {
return casted_nexus<KeyedStoreICNexus>()->GetKeyedAccessStoreMode();
}
« no previous file with comments | « no previous file | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698