src/type-info.cc - Issue 1912593002: [ic] Restore PROPERTY key tracking in keyed ICs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-info.cc

Issue 1912593002: [ic] Restore PROPERTY key tracking in keyed ICs (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/type-info.cc

diff --git a/src/type-info.cc b/src/type-info.cc

index 87429357e29bd7f10b36f453ff8d2d4a3a09c433..87b727ec17e3b0af104ce9a995daf9c40d0cfd65 100644

--- a/src/type-info.cc

+++ b/src/type-info.cc

@@ -297,7 +297,7 @@ void TypeFeedbackOracle::KeyedPropertyReceiverTypes(

KeyedLoadICNexus nexus(feedback_vector_, slot);

CollectReceiverTypes(&nexus, receiver_types);

*is_string = HasOnlyStringMaps(receiver_types);

- *key_type = nexus.FindFirstName() != NULL ? PROPERTY : ELEMENT;

+ *key_type = nexus.GetKeyType();

}