cc/tiles/tile_manager.cc - Issue 1912513003: cc: Fix regression in TileManager InsertNodeForDecodeTask().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/tiles/tile_manager.cc

Issue 1912513003: cc: Fix regression in TileManager InsertNodeForDecodeTask(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@land_merge_tile_task_runner

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/tiles/tile_manager.cc

diff --git a/cc/tiles/tile_manager.cc b/cc/tiles/tile_manager.cc

index f4d8fc5fbaddf63e8c89a2c235b4af1e9949367c..4f798ff3a3ee5e5ba42af108a5b197614101e988 100644

--- a/cc/tiles/tile_manager.cc

+++ b/cc/tiles/tile_manager.cc

@@ -162,6 +162,8 @@ void InsertNodeForDecodeTask(TaskGraph* graph,

if (task->dependencies().size()) {

prashant.n 2016/04/21 12:19:34 ericrk@, should we create a node for imageuploadta

DCHECK_EQ(task->dependencies().size(), 1u);

auto* dependency = task->dependencies()[0].get();

+ DCHECK(dependency)

+ << "Task |dependencies_| should hold valid dependencies.";

if (!dependency->HasCompleted()) {

InsertNodeForDecodeTask(graph, dependency, category, priority);

graph->edges.push_back(TaskGraph::Edge(dependency, task));

« no previous file with comments | « cc/tiles/gpu_image_decode_controller.cc ('k') | no next file » | no next file with comments »