Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1912433002: Convert //components/proximity_auth from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //components/proximity_auth from scoped_ptr to std::unique_ptr BUG=554298 R=isherman@chromium.org Committed: https://crrev.com/2f01269f405de0dfd12cb1dc56459c4492d65b8b Cr-Commit-Position: refs/heads/master@{#388623}

Patch Set 1 #

Total comments: 9

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -484 lines) Patch
M components/proximity_auth/authenticator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_characteristics_finder_unittest.cc View 8 chunks +15 lines, -14 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection.h View 5 chunks +8 lines, -7 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h View 4 chunks +5 lines, -5 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc View 1 9 chunks +16 lines, -15 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_unittest.cc View 20 chunks +48 lines, -31 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_device_whitelist.h View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_device_whitelist.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_device_whitelist_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/proximity_auth/ble/fake_wire_message.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/proximity_auth/ble/fake_wire_message.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M components/proximity_auth/bluetooth_connection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/bluetooth_connection.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/proximity_auth/bluetooth_connection_finder.h View 3 chunks +4 lines, -3 lines 0 comments Download
M components/proximity_auth/bluetooth_connection_finder.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/proximity_auth/bluetooth_connection_finder_unittest.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M components/proximity_auth/bluetooth_connection_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/bluetooth_throttler_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/bluetooth_throttler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/bluetooth_throttler_impl_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/proximity_auth/connection.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/proximity_auth/connection.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/connection_finder.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/proximity_auth/connection_unittest.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_access_token_fetcher_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_client_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_client_impl.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_client_impl_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_device_manager.h View 5 chunks +11 lines, -10 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_device_manager.cc View 6 chunks +12 lines, -9 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_device_manager_unittest.cc View 10 chunks +15 lines, -12 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_enroller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_enroller_impl.h View 3 chunks +7 lines, -6 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_enroller_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_enroller_impl_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_enrollment_manager.h View 6 chunks +13 lines, -12 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_enrollment_manager.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_enrollment_manager_unittest.cc View 12 chunks +17 lines, -16 lines 0 comments Download
M components/proximity_auth/cryptauth/mock_cryptauth_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/cryptauth/mock_cryptauth_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/cryptauth/sync_scheduler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/proximity_auth/cryptauth/sync_scheduler_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/cryptauth/sync_scheduler_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/proximity_auth/cryptauth/sync_scheduler_impl_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M components/proximity_auth/cryptauth_enroller_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/cryptauth_enroller_factory_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/proximity_auth/device_to_device_authenticator.h View 4 chunks +4 lines, -4 lines 0 comments Download
M components/proximity_auth/device_to_device_authenticator.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M components/proximity_auth/device_to_device_authenticator_unittest.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M components/proximity_auth/device_to_device_secure_context.h View 3 chunks +4 lines, -3 lines 0 comments Download
M components/proximity_auth/device_to_device_secure_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/device_to_device_secure_context_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M components/proximity_auth/fake_connection.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/proximity_auth/fake_connection.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M components/proximity_auth/messenger_impl.h View 4 chunks +6 lines, -6 lines 0 comments Download
M components/proximity_auth/messenger_impl.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M components/proximity_auth/messenger_impl_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M components/proximity_auth/messenger_observer.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/proximity_auth/mock_proximity_auth_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/proximity_auth/mock_proximity_auth_client.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M components/proximity_auth/proximity_auth_client.h View 2 chunks +5 lines, -3 lines 0 comments Download
M components/proximity_auth/proximity_auth_pref_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/proximity_auth_pref_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/proximity_auth_pref_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/proximity_auth_system.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl.h View 3 chunks +7 lines, -6 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.h View 4 chunks +12 lines, -11 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl_unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M components/proximity_auth/remote_device_loader.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/remote_device_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/remote_device_loader_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/proximity_auth/remote_status_update.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/remote_status_update.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M components/proximity_auth/remote_status_update_unittest.cc View 12 chunks +13 lines, -13 lines 0 comments Download
M components/proximity_auth/screenlock_bridge.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/proximity_auth/screenlock_bridge.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/throttled_bluetooth_connection_finder.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/proximity_auth/throttled_bluetooth_connection_finder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/throttled_bluetooth_connection_finder_unittest.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M components/proximity_auth/unlock_manager.h View 4 chunks +4 lines, -4 lines 0 comments Download
M components/proximity_auth/unlock_manager.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/proximity_auth/unlock_manager_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.h View 3 chunks +11 lines, -11 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.cc View 16 chunks +29 lines, -24 lines 0 comments Download
M components/proximity_auth/webui/reachable_phone_flow.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/wire_message.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/wire_message.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M components/proximity_auth/wire_message_unittest.cc View 19 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
This is largely a search and replace. There's probably some IWYU errors (files that don't ...
4 years, 8 months ago (2016-04-20 22:00:26 UTC) #1
Ilya Sherman
LGTM % nits. Thanks! https://codereview.chromium.org/1912433002/diff/1/components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc File components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc (right): https://codereview.chromium.org/1912433002/diff/1/components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc#newcode76 components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc:76: // (CreateConnection). nit: Please rewrap ...
4 years, 8 months ago (2016-04-20 22:08:57 UTC) #2
dcheng
https://codereview.chromium.org/1912433002/diff/1/components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc File components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc (right): https://codereview.chromium.org/1912433002/diff/1/components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc#newcode76 components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc:76: // (CreateConnection). On 2016/04/20 at 22:08:56, Ilya Sherman wrote: ...
4 years, 8 months ago (2016-04-20 22:13:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912433002/20001
4 years, 8 months ago (2016-04-20 22:14:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 00:19:50 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:28:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f01269f405de0dfd12cb1dc56459c4492d65b8b
Cr-Commit-Position: refs/heads/master@{#388623}

Powered by Google App Engine
This is Rietveld 408576698