Issue 1911443002: Associate compile-time errors with elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1911443002: Associate compile-time errors with elements. (Closed)

Created:
4 years, 8 months ago by ahe

Modified:
4 years, 8 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Associate compile-time errors with elements. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/f3498e4c9d4625b849fc128517afe78a35ce2db6

Patch Set 1 #

Patch Set 2 : Merged with 111a794141cd313460e4fe2593cfea9862fe1c0f #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -15 lines)			Patch
M	pkg/compiler/lib/src/compiler.dart	View	1	5 chunks	+30 lines, -12 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View		1 chunk	+10 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/class_hierarchy.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

Based on the following Dartino patches: https://codereview.chromium.org/1851433002 https://codereview.chromium.org/1525603002 But I'm attempting to land this on ...

4 years, 8 months ago (2016-04-20 16:00:09 UTC) #2

ahe

4 years, 8 months ago (2016-04-25 14:28:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f3498e4c9d4625b849fc128517afe78a35ce2db6 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages