Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1851433002: Better record compile-time errors on elements (Closed)

Created:
4 years, 8 months ago by zarah
Modified:
4 years, 8 months ago
Reviewers:
Johnni Winther, ahe
CC:
fletch+reviews_googlegroups.com
Base URL:
https://github.com/dart-lang/sdk.git@_temporary_fletch_patches
Target Ref:
refs/heads/_temporary_fletch_patches
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 3 chunks +18 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
zarah
4 years, 8 months ago (2016-03-31 09:40:25 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/1851433002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1851433002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1464 pkg/compiler/lib/src/compiler.dart:1464: elementsWithCompileTimeErrors. Maybe just: if (element == null) { ...
4 years, 8 months ago (2016-03-31 09:59:34 UTC) #3
zarah
Committed patchset #2 (id:20001) manually as 3c0fbecf252e287050b9b3d0987c336a33e9d99b (presubmit successful).
4 years, 8 months ago (2016-03-31 13:30:24 UTC) #5
zarah
4 years, 8 months ago (2016-04-01 07:29:52 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1851433002/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1851433002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:1464: elementsWithCompileTimeErrors.
On 2016/03/31 09:59:34, Johnni Winther wrote:
> Maybe just:
> 
> if (element == null) {
>   // ....
>   element = mainFunction;
> }
> elementsWithCompileTimeError.putIfAbsent(element, ...

Done.

Powered by Google App Engine
This is Rietveld 408576698