Associate compile-time errors with elements

Associate compile-time errors with elements
BUG=
R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/a5163f3595ccc4f41147a552c31c33090fe3970b

[sigurdm, 2015-12-14 11:10:41]

Patchset #1 (id:1) has been deleted

[sigurdm, 2015-12-14 11:11:36]

sigurdm@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2015-12-14 11:31:21]

lgtm

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:1423:
assert(generateCodeWithCompileTimeErrors);
Change the approach to only store message when
[generateCodeWithCompileTimeErrors] is true.

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:1571: "function () { throw new
Error('Compile time error in $element') }");
We could use the message here as well.

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/class_hierarchy.dart (right):

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/class_hierarchy.dart:223:
reporter.reportError(message);
This change doesn't seem to be needed.

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:1352:
compiler.elementHasCompileTimeError(element)) return false;
Add brace around `return false;` now that the statement spans multiple lines.

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:2134:
compiler.elementHasCompileTimeError(member)) return;
Ditto.

[sigurdm, 2015-12-14 12:07:44]

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:1423:
assert(generateCodeWithCompileTimeErrors);
On 2015/12/14 11:31:20, Johnni Winther wrote:
> Change the approach to only store message when
> [generateCodeWithCompileTimeErrors] is true.

Done.

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:1571: "function () { throw new
Error('Compile time error in $element') }");
On 2015/12/14 11:31:20, Johnni Winther wrote:
> We could use the message here as well.

Done.

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/class_hierarchy.dart (right):

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/class_hierarchy.dart:223:
reporter.reportError(message);
On 2015/12/14 11:31:20, Johnni Winther wrote:
> This change doesn't seem to be needed.

Done.

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:1352:
compiler.elementHasCompileTimeError(element)) return false;
On 2015/12/14 11:31:20, Johnni Winther wrote:
> Add brace around `return false;` now that the statement spans multiple lines.

Done.

https://codereview.chromium.org/1525603002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:2134:
compiler.elementHasCompileTimeError(member)) return;
On 2015/12/14 11:31:20, Johnni Winther wrote:
> Ditto.

Done.

[sigurdm, 2015-12-15 09:51:22]

Description was changed from

==========
Assiciate compile-time errors with elements
BUG=
==========

to

==========
Associate compile-time errors with elements
BUG=
==========

[sigurdm, 2015-12-15 09:56:50]

Description was changed from

==========
Associate compile-time errors with elements
BUG=
==========

to

==========
Associate compile-time errors with elements
BUG=
R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a5163f3595ccc4f41147a552c31c33090fe3970b
==========

[sigurdm, 2015-12-15 09:56:51]

Committed patchset #2 (id:40001) manually as
a5163f3595ccc4f41147a552c31c33090fe3970b (presubmit successful).