Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1912023003: CC Animation: Remove Observers and Observations in namings. (Closed)

Created:
4 years, 8 months ago by loyso (OOO)
Modified:
4 years, 7 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@observertype
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Remove Observers and Observations in namings. BUG=595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/34e7ffb72463d53265455eb1b81e4eb1792fbc4e Cr-Commit-Position: refs/heads/master@{#389683}

Patch Set 1 #

Patch Set 2 : Use Affected term. #

Patch Set 3 : Rename it in .cc comments as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -295 lines) Patch
M cc/animation/animation.h View 2 chunks +14 lines, -14 lines 0 comments Download
M cc/animation/animation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/animation/animation_host.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/animation/element_animations.h View 1 8 chunks +41 lines, -45 lines 0 comments Download
M cc/animation/element_animations.cc View 1 2 29 chunks +147 lines, -149 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 29 chunks +69 lines, -71 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 2 chunks +12 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
loyso (OOO)
4 years, 8 months ago (2016-04-22 05:43:34 UTC) #4
Ian Vollick
On 2016/04/22 05:43:34, loyso wrote: lgtm.
4 years, 8 months ago (2016-04-22 13:45:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912023003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912023003/40001
4 years, 7 months ago (2016-04-26 01:04:01 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-26 03:30:42 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 03:33:05 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/34e7ffb72463d53265455eb1b81e4eb1792fbc4e
Cr-Commit-Position: refs/heads/master@{#389683}

Powered by Google App Engine
This is Rietveld 408576698