Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1911253002: Never include_isolate or allow_embedded_addresses. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Never include_isolate or allow_embedded_addresses. Makes the JIT PIC on non-IA32 like precompilation, a prerequisite for caching code across processes. R=fschneider@google.com, johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/05d8185470ee3e9a00eee92f3d84a400e98f2363

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -431 lines) Patch
M runtime/vm/assembler_arm.h View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 6 chunks +13 lines, -34 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 1 chunk +3 lines, -6 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 10 chunks +24 lines, -71 lines 0 comments Download
M runtime/vm/assembler_dbc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/assembler_ia32.h View 1 chunk +4 lines, -8 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 6 chunks +24 lines, -75 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 chunk +3 lines, -6 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 9 chunks +23 lines, -79 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +4 lines, -8 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 11 chunks +22 lines, -53 lines 0 comments Download
M runtime/vm/flag_list.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 5 chunks +5 lines, -9 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 5 chunks +5 lines, -9 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 5 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 8 months ago (2016-04-22 03:19:23 UTC) #2
Cutch
LGTM!
4 years, 8 months ago (2016-04-22 13:56:23 UTC) #3
Florian Schneider
lgtm
4 years, 8 months ago (2016-04-22 15:49:06 UTC) #4
rmacnak
4 years, 8 months ago (2016-04-23 03:47:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
05d8185470ee3e9a00eee92f3d84a400e98f2363 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698