Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: runtime/vm/stub_code_arm.cc

Issue 1911253002: Never include_isolate or allow_embedded_addresses. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier_x64.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_arm.cc
diff --git a/runtime/vm/stub_code_arm.cc b/runtime/vm/stub_code_arm.cc
index e5a03c7d9fe114a4dd244015d202f160b52efb3e..8e85852851d1c2be261e31e827fa002ed8c1adfe 100644
--- a/runtime/vm/stub_code_arm.cc
+++ b/runtime/vm/stub_code_arm.cc
@@ -625,8 +625,7 @@ void StubCode::GenerateAllocateArrayStub(Assembler* assembler) {
__ b(&slow_case, GT);
const intptr_t cid = kArrayCid;
- __ MaybeTraceAllocation(cid, R4, &slow_case,
- /* inline_isolate = */ false);
+ __ MaybeTraceAllocation(cid, R4, &slow_case);
const intptr_t fixed_size = sizeof(RawArray) + kObjectAlignment - 1;
__ LoadImmediate(R9, fixed_size);
@@ -653,7 +652,7 @@ void StubCode::GenerateAllocateArrayStub(Assembler* assembler) {
// Successfully allocated the object(s), now update top to point to
// next object start and initialize the object.
- __ LoadAllocationStatsAddress(R3, cid, /* inline_isolate = */ false);
+ __ LoadAllocationStatsAddress(R3, cid);
__ str(NOTFP, Address(R8, Heap::TopOffset(space)));
__ add(R0, R0, Operand(kHeapObjectTag));
@@ -859,8 +858,7 @@ void StubCode::GenerateAllocateContextStub(Assembler* assembler) {
ASSERT(kSmiTagShift == 1);
__ bic(R2, R2, Operand(kObjectAlignment - 1));
- __ MaybeTraceAllocation(kContextCid, R8, &slow_case,
- /* inline_isolate = */ false);
+ __ MaybeTraceAllocation(kContextCid, R8, &slow_case);
// Now allocate the object.
// R1: number of context variables.
// R2: object size.
@@ -891,7 +889,7 @@ void StubCode::GenerateAllocateContextStub(Assembler* assembler) {
// R2: object size.
// R3: next object start.
// R9: heap.
- __ LoadAllocationStatsAddress(R4, cid, /* inline_isolate = */ false);
+ __ LoadAllocationStatsAddress(R4, cid);
__ str(R3, Address(R9, Heap::TopOffset(space)));
__ add(R0, R0, Operand(kHeapObjectTag));
@@ -1083,7 +1081,7 @@ void StubCode::GenerateAllocationStubForClass(Assembler* assembler,
// Load the address of the allocation stats table. We split up the load
// and the increment so that the dependent load is not too nearby.
- __ LoadAllocationStatsAddress(R9, cls.id(), /* inline_isolate = */ false);
+ __ LoadAllocationStatsAddress(R9, cls.id());
// R0: new object start.
// R1: next object start.
« no previous file with comments | « runtime/vm/intrinsifier_x64.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698