Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 1911253002: Never include_isolate or allow_embedded_addresses. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc
index 2a4ed9bb5e16afa745624037e64f444cc40ed16a..772e39b0a5b2918a734789e0288c910194e7c9b8 100644
--- a/runtime/vm/stub_code_ia32.cc
+++ b/runtime/vm/stub_code_ia32.cc
@@ -564,8 +564,7 @@ void StubCode::GenerateAllocateArrayStub(Assembler* assembler) {
__ MaybeTraceAllocation(kArrayCid,
EAX,
&slow_case,
- Assembler::kFarJump,
- /* inline_isolate = */ false);
+ Assembler::kFarJump);
const intptr_t fixed_size = sizeof(RawArray) + kObjectAlignment - 1;
__ leal(EBX, Address(EDX, TIMES_2, fixed_size)); // EDX is Smi.
@@ -597,8 +596,7 @@ void StubCode::GenerateAllocateArrayStub(Assembler* assembler) {
__ movl(Address(EDI, Heap::TopOffset(space)), EBX);
__ subl(EBX, EAX);
__ addl(EAX, Immediate(kHeapObjectTag));
- __ UpdateAllocationStatsWithSize(cid, EBX, EDI, space,
- /* inline_isolate = */ false);
+ __ UpdateAllocationStatsWithSize(cid, EBX, EDI, space);
// Initialize the tags.
// EAX: new object start as a tagged pointer.
@@ -803,8 +801,7 @@ void StubCode::GenerateAllocateContextStub(Assembler* assembler) {
__ MaybeTraceAllocation(kContextCid,
EAX,
&slow_case,
- Assembler::kFarJump,
- /* inline_isolate = */ false);
+ Assembler::kFarJump);
// Now allocate the object.
// EDX: number of context variables.
@@ -839,8 +836,7 @@ void StubCode::GenerateAllocateContextStub(Assembler* assembler) {
__ subl(EBX, EAX);
__ addl(EAX, Immediate(kHeapObjectTag));
// Generate isolate-independent code to allow sharing between isolates.
- __ UpdateAllocationStatsWithSize(cid, EBX, EDI, space,
- /* inline_isolate = */ false);
+ __ UpdateAllocationStatsWithSize(cid, EBX, EDI, space);
// Calculate the size tag.
// EAX: new object.
@@ -1037,8 +1033,7 @@ void StubCode::GenerateAllocationStubForClass(
__ j(ABOVE_EQUAL, &slow_case);
}
__ movl(Address(EDI, Heap::TopOffset(space)), EBX);
- __ UpdateAllocationStats(cls.id(), ECX, space,
- /* inline_isolate = */ false);
+ __ UpdateAllocationStats(cls.id(), ECX, space);
// EAX: new object start (untagged).
// EBX: next object start.
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698