Don't apply device pixel ratio to filter params, either shorthand or reference. We will take c…

Don't do HiDPI scaling of accelerated filter params in Blink.

This puts HiDPI scaling of filter parameters behind a
compile-time flag (that is already enabled in Chrome). CC
will take care of DPR on the accelerated side in an upcoming
change, and FilterEffectRenderer will take care of it on the
raster side.

BUG=281516
R=jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168788

[Stephen White, 2014-03-07 19:52:33]

jamesr: PTAL

[jamesr, 2014-03-08 01:52:29]

Why do we need a compile-time flag if it's already set?

What tests cover this?

[Stephen White, 2014-03-08 01:59:39]

On 2014/03/08 01:52:29, jamesr wrote:
> Why do we need a compile-time flag if it's already set?

The flag is set in Chrome, not Blink. We need a way to turn off the old Blink
behaviour from Chrome-side, when landing the equivalent CC changes (see
https://codereview.chromium.org/191123002/)

> What tests cover this?

css3/filters/effect-reference-hidpi.html
css3/filters/effect-reference-hidpi-hw.html

[Stephen White, 2014-03-08 02:13:51]

On 2014/03/08 01:59:39, Stephen White wrote:
> On 2014/03/08 01:52:29, jamesr wrote:
> > Why do we need a compile-time flag if it's already set?
> 
> The flag is set in Chrome, not Blink. We need a way to turn off the old Blink
> behaviour from Chrome-side, when landing the equivalent CC changes (see
> https://codereview.chromium.org/191123002/)
> 
> > What tests cover this?
> 
> css3/filters/effect-reference-hidpi.html
> css3/filters/effect-reference-hidpi-hw.html

In other words, this change will have zero effect on currently-running code, but
it'll allow me to switch from Blink-side HiDPI scaling to CC-side, in one Chrome
change.

[jamesr, 2014-03-08 03:45:30]

This stuff's tricky, but I think this lgtm.  What tests cover this functionality
in case we break it?

[Stephen White, 2014-03-08 03:56:44]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2014-03-08 03:56:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/191053003/60001

[Stephen White, 2014-03-08 03:56:59]

On 2014/03/08 03:45:30, jamesr wrote:
> This stuff's tricky, but I think this lgtm.  What tests cover this
functionality
> in case we break it?

css3/filters/effect-reference-hidpi.html
css3/filters/effect-reference-hidpi-hw.html

[commit-bot: I haz the power, 2014-03-08 10:31:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-08 10:31:23]

Try jobs failed on following builders: linux_blink

[Stephen White, 2014-03-08 12:53:41]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2014-03-08 12:53:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/191053003/60001

[commit-bot: I haz the power, 2014-03-08 13:51:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-08 13:51:38]

Try jobs failed on following builders: linux_blink

[Stephen White, 2014-03-08 15:58:19]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2014-03-08 15:58:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/191053003/60001

[commit-bot: I haz the power, 2014-03-08 16:02:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-08 16:02:47]

Try jobs failed on following builders: linux_blink

[Stephen White, 2014-03-08 18:13:07]

Committed patchset #4 manually as r168788 (presubmit successful).