Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 191053003: Don't apply device pixel ratio to filter params, either shorthand or reference. We will take c… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove TestExpectations changes Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/FilterEffectRenderer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 3915 matching lines...) Expand 10 before | Expand all | Expand 10 after
3926 { 3926 {
3927 const FilterOperations& filters = style->filter(); 3927 const FilterOperations& filters = style->filter();
3928 if (filters.hasReferenceFilter()) { 3928 if (filters.hasReferenceFilter()) {
3929 for (size_t i = 0; i < filters.size(); ++i) { 3929 for (size_t i = 0; i < filters.size(); ++i) {
3930 FilterOperation* filterOperation = filters.operations().at(i).get(); 3930 FilterOperation* filterOperation = filters.operations().at(i).get();
3931 if (filterOperation->type() != FilterOperation::REFERENCE) 3931 if (filterOperation->type() != FilterOperation::REFERENCE)
3932 continue; 3932 continue;
3933 ReferenceFilterOperation* referenceOperation = toReferenceFilterOper ation(filterOperation); 3933 ReferenceFilterOperation* referenceOperation = toReferenceFilterOper ation(filterOperation);
3934 // FIXME: Cache the ReferenceFilter if it didn't change. 3934 // FIXME: Cache the ReferenceFilter if it didn't change.
3935 RefPtr<ReferenceFilter> referenceFilter = ReferenceFilter::create(); 3935 RefPtr<ReferenceFilter> referenceFilter = ReferenceFilter::create();
3936 #ifdef BLINK_SCALE_FILTERS_AT_RECORD_TIME
3936 float zoom = style->effectiveZoom() * WebCore::deviceScaleFactor(ren derer()->frame()); 3937 float zoom = style->effectiveZoom() * WebCore::deviceScaleFactor(ren derer()->frame());
3938 #else
3939 float zoom = style->effectiveZoom();
3940 #endif
3937 referenceFilter->setAbsoluteTransform(AffineTransform().scale(zoom, zoom)); 3941 referenceFilter->setAbsoluteTransform(AffineTransform().scale(zoom, zoom));
3938 referenceFilter->setLastEffect(ReferenceFilterBuilder::build(referen ceFilter.get(), renderer(), referenceFilter->sourceGraphic(), 3942 referenceFilter->setLastEffect(ReferenceFilterBuilder::build(referen ceFilter.get(), renderer(), referenceFilter->sourceGraphic(),
3939 referenceOperation)); 3943 referenceOperation));
3940 referenceOperation->setFilter(referenceFilter.release()); 3944 referenceOperation->setFilter(referenceFilter.release());
3941 } 3945 }
3942 } 3946 }
3943 3947
3944 return filters; 3948 return filters;
3945 } 3949 }
3946 3950
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
4063 } 4067 }
4064 } 4068 }
4065 4069
4066 void showLayerTree(const WebCore::RenderObject* renderer) 4070 void showLayerTree(const WebCore::RenderObject* renderer)
4067 { 4071 {
4068 if (!renderer) 4072 if (!renderer)
4069 return; 4073 return;
4070 showLayerTree(renderer->enclosingLayer()); 4074 showLayerTree(renderer->enclosingLayer());
4071 } 4075 }
4072 #endif 4076 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/FilterEffectRenderer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698