Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1910103002: Give setup.exe its version resource back in the GN build. (Closed)

Created:
4 years, 8 months ago by grt (UTC plus 2)
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give setup.exe its version resource back in the GN build. BUG=605648 Committed: https://crrev.com/40a09e787b4aba33fcd27672b4763fecf13c3623 Cr-Commit-Position: refs/heads/master@{#388855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/installer/setup/BUILD.gn View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
grt (UTC plus 2)
PTAL, thanks.
4 years, 8 months ago (2016-04-21 18:36:22 UTC) #2
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-21 18:43:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910103002/1
4 years, 8 months ago (2016-04-21 18:47:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 19:41:58 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:37:51 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/40a09e787b4aba33fcd27672b4763fecf13c3623
Cr-Commit-Position: refs/heads/master@{#388855}

Powered by Google App Engine
This is Rietveld 408576698