Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Side by Side Diff: chrome/installer/setup/BUILD.gn

Issue 1910103002: Give setup.exe its version resource back in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//chrome/version.gni")
5 import("//testing/test.gni") 6 import("//testing/test.gni")
6 7
7 if (is_win) { 8 if (is_win) {
8 executable("setup") { 9 executable("setup") {
9 sources = [ 10 sources = [
10 "setup.ico", 11 "setup.ico",
11 "setup.rc", 12 "setup.rc",
12 "setup_exe_version.rc.version", 13 "setup_exe_version.rc.version",
13 "setup_main.cc", 14 "setup_main.cc",
14 "setup_main.h", 15 "setup_main.h",
15 "setup_resource.h", 16 "setup_resource.h",
16 "uninstall.cc", 17 "uninstall.cc",
17 "uninstall.h", 18 "uninstall.h",
18 ] 19 ]
19 20
20 configs -= [ "//build/config/win:console" ] 21 configs -= [ "//build/config/win:console" ]
21 configs += [ "//build/config/win:windowed" ] 22 configs += [ "//build/config/win:windowed" ]
22 23
23 deps = [ 24 deps = [
24 ":lib", 25 ":lib",
26 ":setup_exe_version",
25 "//build/config/sanitizers:deps", 27 "//build/config/sanitizers:deps",
26 "//build/win:default_exe_manifest", 28 "//build/win:default_exe_manifest",
27 "//components/crash/content/app:app", 29 "//components/crash/content/app:app",
28 ] 30 ]
29 } 31 }
30 32
31 source_set("lib") { 33 source_set("lib") {
32 sources = [ 34 sources = [
33 "app_launcher_installer.cc", 35 "app_launcher_installer.cc",
34 "app_launcher_installer.h", 36 "app_launcher_installer.h",
(...skipping 27 matching lines...) Expand all
62 "//components/crash/content/app:lib", 64 "//components/crash/content/app:lib",
63 "//components/crash/core/common", 65 "//components/crash/core/common",
64 "//content/public/common:static_switches", 66 "//content/public/common:static_switches",
65 "//courgette:courgette_lib", 67 "//courgette:courgette_lib",
66 "//rlz:rlz_lib", 68 "//rlz:rlz_lib",
67 "//third_party/bspatch", 69 "//third_party/bspatch",
68 "//third_party/zlib", 70 "//third_party/zlib",
69 ] 71 ]
70 } 72 }
71 73
74 process_version("setup_exe_version") {
75 template_file = "setup_exe_version.rc.version"
76 output = "$target_gen_dir/setup_exe_version.rc"
77 }
78
72 # This test covers the mini installer and setup tests. 79 # This test covers the mini installer and setup tests.
73 test("setup_unittests") { 80 test("setup_unittests") {
74 sources = [ 81 sources = [
75 "archive_patch_helper_unittest.cc", 82 "archive_patch_helper_unittest.cc",
76 "install_unittest.cc", 83 "install_unittest.cc",
77 "install_worker_unittest.cc", 84 "install_worker_unittest.cc",
78 "memory_unittest.cc", 85 "memory_unittest.cc",
79 "run_all_unittests.cc", 86 "run_all_unittests.cc",
80 "setup_util_unittest.cc", 87 "setup_util_unittest.cc",
81 "setup_util_unittest.h", 88 "setup_util_unittest.h",
82 "update_active_setup_version_work_item_unittest.cc", 89 "update_active_setup_version_work_item_unittest.cc",
83 ] 90 ]
84 91
85 deps = [ 92 deps = [
86 ":lib", 93 ":lib",
87 "//base", 94 "//base",
88 "//base:i18n", 95 "//base:i18n",
89 "//base/test:test_support", 96 "//base/test:test_support",
90 "//chrome/installer/mini_installer:unit_tests", 97 "//chrome/installer/mini_installer:unit_tests",
91 "//testing/gmock", 98 "//testing/gmock",
92 "//testing/gtest", 99 "//testing/gtest",
93 ] 100 ]
94 101
95 data = [ 102 data = [
96 "//chrome/installer/test/data/", 103 "//chrome/installer/test/data/",
97 "//chrome/test/data/installer/", 104 "//chrome/test/data/installer/",
98 ] 105 ]
99 } 106 }
100 } 107 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698