Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: chrome/installer/setup/BUILD.gn

Issue 1910103002: Give setup.exe its version resource back in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/BUILD.gn
diff --git a/chrome/installer/setup/BUILD.gn b/chrome/installer/setup/BUILD.gn
index 25630d745e4ad59082021c7e0648ed587ecda3dd..de0c2aa44b55ab35fefb60b4976fa308e6fceacd 100644
--- a/chrome/installer/setup/BUILD.gn
+++ b/chrome/installer/setup/BUILD.gn
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//chrome/version.gni")
import("//testing/test.gni")
if (is_win) {
@@ -22,6 +23,7 @@ if (is_win) {
deps = [
":lib",
+ ":setup_exe_version",
"//build/config/sanitizers:deps",
"//build/win:default_exe_manifest",
"//components/crash/content/app:app",
@@ -69,6 +71,11 @@ if (is_win) {
]
}
+ process_version("setup_exe_version") {
+ template_file = "setup_exe_version.rc.version"
+ output = "$target_gen_dir/setup_exe_version.rc"
+ }
+
# This test covers the mini installer and setup tests.
test("setup_unittests") {
sources = [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698