Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1909943003: LogDog: Add project support to Storage. (Closed)

Created:
4 years, 8 months ago by dnj
Modified:
4 years, 7 months ago
Reviewers:
Ryan Tseng, iannucci, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://github.com/luci/luci-go@logdog-project-coordinator-services
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Add project support to Storage. BUG= Committed: https://github.com/luci/luci-go/commit/14c6f275f7b5b1615bd071fa363635ca22d88bb0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -93 lines) Patch
M appengine/logdog/coordinator/endpoints/logs/get.go View 1 chunk +1 line, -1 line 0 comments Download
M server/logdog/storage/archive/storage.go View 3 chunks +4 lines, -3 lines 0 comments Download
M server/logdog/storage/bigtable/rowKey.go View 3 chunks +14 lines, -5 lines 0 comments Download
M server/logdog/storage/bigtable/rowKey_test.go View 2 chunks +17 lines, -10 lines 0 comments Download
M server/logdog/storage/bigtable/storage.go View 9 chunks +21 lines, -14 lines 0 comments Download
M server/logdog/storage/bigtable/storage_test.go View 4 chunks +13 lines, -9 lines 0 comments Download
M server/logdog/storage/memory/memory.go View 9 chunks +22 lines, -12 lines 0 comments Download
M server/logdog/storage/memory/memory_test.go View 8 chunks +36 lines, -38 lines 0 comments Download
M server/logdog/storage/storage.go View 4 chunks +6 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1910923002 Patch 80001

Dependent Patchsets:

Issue 1909073002 Patch 40001

Messages

Total messages: 11 (6 generated)
dnj
PTAL
4 years, 8 months ago (2016-04-25 16:44:34 UTC) #3
Ryan Tseng
lgtm https://codereview.chromium.org/1909943003/diff/1/server/logdog/storage/bigtable/rowKey.go File server/logdog/storage/bigtable/rowKey.go (right): https://codereview.chromium.org/1909943003/diff/1/server/logdog/storage/bigtable/rowKey.go#newcode115 server/logdog/storage/bigtable/rowKey.go:115: _, _ = h.Write([]byte(project)) isn't the assignment redundant ...
4 years, 7 months ago (2016-04-28 21:04:31 UTC) #5
dnj
https://codereview.chromium.org/1909943003/diff/1/server/logdog/storage/bigtable/rowKey.go File server/logdog/storage/bigtable/rowKey.go (right): https://codereview.chromium.org/1909943003/diff/1/server/logdog/storage/bigtable/rowKey.go#newcode115 server/logdog/storage/bigtable/rowKey.go:115: _, _ = h.Write([]byte(project)) On 2016/04/28 21:04:31, Ryan Tseng ...
4 years, 7 months ago (2016-04-30 02:56:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909943003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909943003/40001
4 years, 7 months ago (2016-04-30 03:01:47 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 03:10:54 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://github.com/luci/luci-go/commit/14c6f275f7b5b1615bd071fa363635ca22d88bb0

Powered by Google App Engine
This is Rietveld 408576698