Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1909073002: LogDog: Add project namespace to logs endpoint. (Closed)

Created:
4 years, 8 months ago by dnj
Modified:
4 years, 7 months ago
Reviewers:
Ryan Tseng, iannucci, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://github.com/luci/luci-go@logdog-project-storage
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Add project namespace to logs endpoint. BUG= Committed: https://github.com/luci/luci-go/commit/66742d34097700d95c97e60e301a0ff662084f8e

Patch Set 1 #

Patch Set 2 : Updates, works. #

Total comments: 2

Patch Set 3 : Rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1612 lines, -1433 lines) Patch
M appengine/logdog/coordinator/endpoints/logs/get.go View 1 11 chunks +58 lines, -49 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/logs/get_test.go View 1 6 chunks +317 lines, -262 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/logs/list.go View 1 chunk +10 lines, -0 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/logs/list_test.go View 1 7 chunks +28 lines, -10 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/logs/query_test.go View 1 7 chunks +22 lines, -9 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/logs/service.go View 1 2 chunks +21 lines, -0 lines 0 comments Download
M common/api/logdog_coordinator/logs/v1/logs.proto View 10 chunks +43 lines, -33 lines 0 comments Download
M common/api/logdog_coordinator/logs/v1/logs.pb.go View 11 chunks +104 lines, -93 lines 0 comments Download
M common/api/logdog_coordinator/logs/v1/pb.discovery.go View 1 chunk +992 lines, -977 lines 0 comments Download
A common/api/logdog_coordinator/logs/v1/util.go View 1 chunk +17 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1909943003 Patch 40001

Dependent Patchsets:

Issue 1909053003 Patch 40001

Messages

Total messages: 11 (6 generated)
dnj
PTAL
4 years, 8 months ago (2016-04-25 16:42:06 UTC) #3
Ryan Tseng
lgtm https://codereview.chromium.org/1909073002/diff/20001/appengine/logdog/coordinator/endpoints/logs/service.go File appengine/logdog/coordinator/endpoints/logs/service.go (right): https://codereview.chromium.org/1909073002/diff/20001/appengine/logdog/coordinator/endpoints/logs/service.go#newcode49 appengine/logdog/coordinator/endpoints/logs/service.go:49: return nil, grpcutil.Internal log err?
4 years, 7 months ago (2016-04-28 20:45:29 UTC) #5
dnj
https://codereview.chromium.org/1909073002/diff/20001/appengine/logdog/coordinator/endpoints/logs/service.go File appengine/logdog/coordinator/endpoints/logs/service.go (right): https://codereview.chromium.org/1909073002/diff/20001/appengine/logdog/coordinator/endpoints/logs/service.go#newcode49 appengine/logdog/coordinator/endpoints/logs/service.go:49: return nil, grpcutil.Internal On 2016/04/28 20:45:29, Ryan Tseng wrote: ...
4 years, 7 months ago (2016-04-30 02:58:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909073002/40001
4 years, 7 months ago (2016-04-30 03:12:15 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 03:16:39 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/66742d34097700d95c97e60e301a0ff662084f8e

Powered by Google App Engine
This is Rietveld 408576698