Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1910923002: LogDog: Add project namespace to service endpoint. (Closed)

Created:
4 years, 8 months ago by dnj
Modified:
4 years, 7 months ago
Reviewers:
Ryan Tseng, iannucci, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://github.com/luci/luci-go@logdog-project-coordinator-backend
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Add project namespace to service endpoint. BUG= Committed: https://github.com/luci/luci-go/commit/79032fd059955861d87613475be54dad7a610576

Patch Set 1 #

Patch Set 2 : Updates, works. #

Total comments: 2

Patch Set 3 : Rebase? #

Patch Set 4 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1032 lines, -935 lines) Patch
M appengine/logdog/coordinator/coordinatorTest/logStream.go View 1 chunk +1 line, -1 line 0 comments Download
A appengine/logdog/coordinator/endpoints/projectBoundMessage.go View 1 chunk +14 lines, -0 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/services/archiveStream.go View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/services/archiveStream_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/services/getConfig_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/services/loadStream.go View 1 1 chunk +6 lines, -4 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/services/loadStream_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/services/registerStream.go View 1 2 5 chunks +11 lines, -6 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/services/registerStream_test.go View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/services/service.go View 1 2 chunks +12 lines, -0 lines 0 comments Download
M appengine/logdog/coordinator/endpoints/services/terminateStream.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M appengine/logdog/coordinator/logStream.go View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/logdog/coordinator/logStream_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M client/internal/logdog/butler/bundler/bundler.go View 1 chunk +1 line, -1 line 0 comments Download
M common/api/logdog_coordinator/services/v1/pb.discovery.go View 1 1 chunk +810 lines, -795 lines 0 comments Download
M common/api/logdog_coordinator/services/v1/service.proto View 3 chunks +21 lines, -13 lines 0 comments Download
M common/api/logdog_coordinator/services/v1/service.pb.go View 5 chunks +65 lines, -56 lines 0 comments Download
M common/api/logdog_coordinator/services/v1/state.proto View 1 chunk +9 lines, -6 lines 0 comments Download
M common/api/logdog_coordinator/services/v1/state.pb.go View 2 chunks +22 lines, -19 lines 0 comments Download
M common/api/logdog_coordinator/services/v1/util.go View 1 chunk +12 lines, -0 lines 0 comments Download
M common/logdog/types/streamsecret.go View 1 2 3 1 chunk +25 lines, -13 lines 0 comments Download
M server/internal/logdog/collector/collector.go View 1 chunk +1 line, -1 line 0 comments Download
M server/internal/logdog/collector/collector_test.go View 1 chunk +1 line, -1 line 0 comments Download
M server/internal/logdog/collector/utils_test.go View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1910633006 Patch 100001

Dependent Patchsets:

Issue 1909943003 Patch 40001

Messages

Total messages: 11 (6 generated)
dnj
PTAL
4 years, 8 months ago (2016-04-25 16:43:40 UTC) #2
Ryan Tseng
lgtm https://codereview.chromium.org/1910923002/diff/20001/common/logdog/types/streamsecret.go File common/logdog/types/streamsecret.go (right): https://codereview.chromium.org/1910923002/diff/20001/common/logdog/types/streamsecret.go#newcode33 common/logdog/types/streamsecret.go:33: if count != len(buf) { Or just use ...
4 years, 7 months ago (2016-04-28 20:52:04 UTC) #5
dnj
https://codereview.chromium.org/1910923002/diff/20001/common/logdog/types/streamsecret.go File common/logdog/types/streamsecret.go (right): https://codereview.chromium.org/1910923002/diff/20001/common/logdog/types/streamsecret.go#newcode33 common/logdog/types/streamsecret.go:33: if count != len(buf) { On 2016/04/28 20:52:04, Ryan ...
4 years, 7 months ago (2016-04-30 02:51:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910923002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910923002/80001
4 years, 7 months ago (2016-04-30 02:55:48 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 03:01:26 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) as
https://github.com/luci/luci-go/commit/79032fd059955861d87613475be54dad7a610576

Powered by Google App Engine
This is Rietveld 408576698