Remove support for Object.observe

Remove support for Object.observe

The feature was deprecated in M49 and flagged off in M50.
This patch removes it entirely from the codebase.

Committed: https://crrev.com/6a370a6f01b004f0b359aa0e0ce4aa90d40773d0
Cr-Commit-Position: refs/heads/master@{#35714}

[adamk, 2016-04-20 21:24:11]

adamk@chromium.org changed reviewers:
+ bmeurer@chromium.org, hpayer@chromium.org, jkummerow@chromium.org

[adamk, 2016-04-20 21:24:12]

The end of an era.

jkummerow, this one's for you (plus bmeurer for crankshaft and hpayer for heap).

[Jakob Kummerow, 2016-04-21 07:27:02]

jkummerow@chromium.org changed reviewers:
- bmeurer@chromium.org

[Jakob Kummerow, 2016-04-21 07:27:03]

LGTM, thanks!

I think there's some more now-dead code in v8natives.js and objects.h/cc, but
it's probably best to avoid rebasing trouble and land this CL as it is, and
clean up any leftovers as we come across them.

We don't need no bmeurer for src/crankshaft/, as I'm an OWNER there myself.

[Hannes Payer (out of office), 2016-04-21 07:29:56]

heap LGTM

[adamk, 2016-04-21 17:56:43]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-04-21 17:56:44]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1909433003/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-04-21 17:56:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909433003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909433003/40001

[commit-bot: I haz the power, 2016-04-21 20:01:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 20:01:42]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/4673)

[adamk, 2016-04-21 20:03:34]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-04-21 20:03:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909433003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909433003/40001

[commit-bot: I haz the power, 2016-04-21 22:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 22:06:09]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[adamk, 2016-04-21 22:25:03]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-04-21 22:25:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909433003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909433003/40001

[commit-bot: I haz the power, 2016-04-22 00:27:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 00:27:22]

Try jobs failed on following builders:
  v8_mac_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/558)

[adamk, 2016-04-22 01:02:30]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-04-22 01:02:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909433003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909433003/40001

[commit-bot: I haz the power, 2016-04-22 03:05:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 03:05:33]

Try jobs failed on following builders:
  v8_mac_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/562)

[Jakob Kummerow, 2016-04-22 08:39:02]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2016-04-22 08:39:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909433003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909433003/40001

[commit-bot: I haz the power, 2016-04-22 09:01:45]

Committed patchset #3 (id:40001)

[Michael Achenbach, 2016-04-22 09:12:43]

Could you also clean up:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/test/mjsunit/mj...

And maybe skim through the open bug reports that have something to do with
object-observe:
https://bugs.chromium.org/p/v8/issues/list?can=2&q=object-observe&colspec=ID+...

[adamk, 2016-04-22 18:32:20]

On 2016/04/22 09:12:43, Michael Achenbach wrote:
> Could you also clean up:
>
https://code.google.com/p/chromium/codesearch#chromium/src/v8/test/mjsunit/mj...

Gone, thanks for the pointer.

> And maybe skim through the open bug reports that have something to do with
> object-observe:
>
https://bugs.chromium.org/p/v8/issues/list?can=2&q=object-observe&colspec=ID+...

Thanks, closed the ones I found. I used to have a custom ObjectObserve label but
it seems to have been lost in Monorail migration :(

[adamk, 2016-04-22 18:33:27]

Description was changed from

==========
Remove support for Object.observe

The feature was deprecated in M49 and flagged off in M50.
This patch removes it entirely from the codebase.
==========

to

==========
Remove support for Object.observe

The feature was deprecated in M49 and flagged off in M50.
This patch removes it entirely from the codebase.

Committed: http://crrev.com/6a370a6f01b004f0b359aa0e0ce4aa90d40773d0
==========

[commit-bot: I haz the power, 2016-04-22 19:15:05]

Description was changed from

==========
Remove support for Object.observe

The feature was deprecated in M49 and flagged off in M50.
This patch removes it entirely from the codebase.

Committed: http://crrev.com/6a370a6f01b004f0b359aa0e0ce4aa90d40773d0
==========

to

==========
Remove support for Object.observe

The feature was deprecated in M49 and flagged off in M50.
This patch removes it entirely from the codebase.

Committed: https://crrev.com/6a370a6f01b004f0b359aa0e0ce4aa90d40773d0
Cr-Commit-Position: refs/heads/master@{#35714}
==========

[commit-bot: I haz the power, 2016-04-22 19:15:06]

Patchset 3 (id:??) landed as
https://crrev.com/6a370a6f01b004f0b359aa0e0ce4aa90d40773d0
Cr-Commit-Position: refs/heads/master@{#35714}